Tweak PRIF_ATOMIC_LOGICAL_KIND#290
Merged
bonachea merged 2 commits intoBerkeleyLab:mainfrom Jan 27, 2026
Merged
Conversation
* PRIF does not require these parameter values to have any particular kind. flang internally defines these parameters to be default integer, and gfortran generates spurious warnings when they are not so change them to default integer. * Add a HAVE_LOGICAL64 compile-time option to accomodate (theoretical) compilers that provide logical64 but lack selected_logical_kind.
This silences a (harmless) warning
Member
Author
Apologies, this is explained in the commit message:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deploys use of
selected_logical_kindin the definition ofPRIF_ATOMIC_LOGICAL_KINDfor gfortran 15 (the first release version where it appears).This resolves multiple (harmless) warnings from gfortran (15) of the form shown below, and improves our spec compliance.