feat(interpreter/types): Split types into Simple and Complex #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Tests pass, but there's still plenty of optimizations to do. |
Author
|
This should probably be merged with #50 before being merged itself. |
… in complex_type.
…erate Complex Simple types.
lukasfri
force-pushed
the
feat/type-separation
branch
from
f0c212e to
0a75b19
Compare
Author
|
This has been reworked to be dependent on #50 , meaning that needs to be merged first. After fixing a bug with the generator, all tests now pass, with just a bunch of clippy warnings being left to fix. Combining #50 with this PR really shows the power of splitting the types. SimpleVariantBuilder only ever touches the new SimpleTypeVariant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #43