Skip to content

Add test coverage for nether world border filtering #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tastybento merged 2 commits into from
Dec 16, 2025
Merged

Add test coverage for nether world border filtering #152

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc7dc0d
Initial plan
Copilot Dec 16, 2025
c38c376
Add test cases for nether world border behavior
Copilot Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions src/test/java/world/bentobox/border/listeners/ShowVirtualWorldBorderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,12 @@

import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;

import org.bukkit.Bukkit;
import org.bukkit.World.Environment;
import org.bukkit.WorldBorder;
import org.bukkit.entity.Player;
import org.bukkit.util.Vector;
Expand Down Expand Up @@ -123,4 +125,39 @@ public void testHideBorder() {
verify(mockPlayer).setWorldBorder(null);
}

/**
* Test method for {@link world.bentobox.border.listeners.ShowVirtualWorldBorder#showBorder(org.bukkit.entity.Player, world.bentobox.bentobox.database.objects.Island)}.
* Tests that border is shown when player is in an island nether world.
*/
@Test
public void testShowBorderInIslandNetherWorld() {
// Setup: Player is in a nether environment that IS an island nether world
when(world.getEnvironment()).thenReturn(Environment.NETHER);
when(iwm.isIslandNether(world)).thenReturn(true);
when(addon.getPlugin()).thenReturn(plugin);

svwb.showBorder(mockPlayer, island);

// Verify that the border was set (border should show in island nether worlds)
verify(mockPlayer).setWorldBorder(wb);
verify(wb).setSize(200.0D);
}

/**
* Test method for {@link world.bentobox.border.listeners.ShowVirtualWorldBorder#showBorder(org.bukkit.entity.Player, world.bentobox.bentobox.database.objects.Island)}.
* Tests that border is NOT shown when player is in a non-island nether world.
*/
@Test
public void testShowBorderInNonIslandNetherWorld() {
// Setup: Player is in a nether environment that is NOT an island nether world
when(world.getEnvironment()).thenReturn(Environment.NETHER);
when(iwm.isIslandNether(world)).thenReturn(false);
when(addon.getPlugin()).thenReturn(plugin);

svwb.showBorder(mockPlayer, island);

// Verify that the border was NOT set (border should not show in non-island nether worlds)
verify(mockPlayer, never()).setWorldBorder(any());
}

}