Skip to content

Conversation

@N6REJ
Copy link
Contributor

@N6REJ N6REJ commented Jan 16, 2026

PR Type

Enhancement, Other


Description

  • Add Ghostscript 10.06.0 configuration with Windows batch script

  • Update bundle release date to 2026.1.15

  • Remove Eclipse project files and editor configuration

  • Remove Gradle build test script


Diagram Walkthrough

flowchart LR
  A["Ghostscript 10.06.0"] -- "Add configuration" --> B["bearsampp.conf"]
  A -- "Add CID font mapping" --> C["update_cidfmap.bat"]
  D["build.properties"] -- "Update release date" --> E["2026.1.15"]
  F["Project files"] -- "Remove" --> G["Cleanup"]
Loading

File Walkthrough

Relevant files
Configuration changes
update_cidfmap.bat
Add CID font mapping update script                                             

bin/ghostscript10.06.0/update_cidfmap.bat

  • New batch script for updating CID font mapping
  • Executes Ghostscript with font directory and CID font map
    configuration
  • Uses gswin64c.exe console executable
+4/-0     
bearsampp.conf
Add Ghostscript 10.06.0 configuration file                             

bin/ghostscript10.06.0/bearsampp.conf

  • New configuration file for Ghostscript 10.06.0
  • Defines Ghostscript version and executable paths
  • Specifies both GUI and console executable locations
  • Sets bundle release version placeholder
+5/-0     
build.properties
Update bundle release date                                                             

build.properties

  • Update bundle release date from 2025.7.31 to 2026.1.15
+1/-1     
Miscellaneous
test-gradle-build.bat
Remove Gradle build test script                                                   

test-gradle-build.bat

  • Remove entire Gradle build test script
  • Script contained 100 lines of test cases for various Gradle tasks
+0/-100 
.project
Remove Eclipse project file                                                           

.project

  • Remove Eclipse project description file
  • Cleanup of IDE-specific configuration
+0/-11   
org.eclipse.core.resources.prefs
Remove Eclipse settings file                                                         

.settings/org.eclipse.core.resources.prefs

  • Remove Eclipse editor preferences file
  • Cleanup of IDE-specific settings
+0/-2     
editorconfig
Remove EditorConfig file                                                                 

editorconfig

  • Remove EditorConfig file with coding style rules
  • Cleanup of editor configuration for unified coding style
+0/-16   

@N6REJ N6REJ added the enhancement ✨ Improve program label Jan 16, 2026
@qodo-code-review
Copy link

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
Untrusted binary execution

Description: The script executes a relative-path binary (bin\gswin64c.exe) after changing to the script
directory, so if an attacker can modify the contents of bin/ (or replace gswin64c.exe),
running this batch file would execute attacker-controlled code.
update_cidfmap.bat [3-4]

Referred Code
cd %~dp0
bin\gswin64c.exe -q -dBATCH -sFONTDIR=c:/windows/fonts -sCIDFMAP=lib/cidfmap lib/mkcidfm.ps
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status:
No error checks: The batch script invokes gswin64c.exe without checking for missing executables, failed cd,
or non-zero exit codes, so failures may be silent or hard to diagnose.

Referred Code
@ECHO OFF

cd %~dp0
bin\gswin64c.exe -q -dBATCH -sFONTDIR=c:/windows/fonts -sCIDFMAP=lib/cidfmap lib/mkcidfm.ps

Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-code-review
Copy link

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Use an environment variable for portability

Replace the hardcoded font directory c:/windows/fonts with the %SystemRoot%
environment variable to improve script portability across different Windows
installations.

bin/ghostscript10.06.0/update_cidfmap.bat [4]

-bin\gswin64c.exe -q -dBATCH -sFONTDIR=c:/windows/fonts -sCIDFMAP=lib/cidfmap lib/mkcidfm.ps
+bin\gswin64c.exe -q -dBATCH -sFONTDIR="%SystemRoot%/fonts" -sCIDFMAP=lib/cidfmap lib/mkcidfm.ps
  • Apply / Chat
Suggestion importance[1-10]: 6

__

Why: The suggestion correctly identifies a hardcoded path that harms portability and proposes using the %SystemRoot% environment variable, which is the standard and more robust solution.

Low
  • More

@jwaisner jwaisner merged commit e9beee6 into main Jan 25, 2026
2 checks passed
@jwaisner jwaisner deleted the 10.06 branch January 25, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ Improve program

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants