Skip to content

Remove unnecessary @pytest.mark.skip_if_max_rank_greater_than(1) #5215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajpotts merged 1 commit into from
Dec 29, 2025
Merged

Remove unnecessary @pytest.mark.skip_if_max_rank_greater_than(1) #5215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions tests/comm_diagnostics_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@

@pytest.mark.requires_chapel_module("CommDiagnosticsMsg")
class TestCommDiagnostics:
@pytest.mark.skip_if_max_rank_greater_than(1)
def test_comm_diagnostics_docstrings(self):
import doctest

Expand All @@ -51,14 +50,12 @@ def test_comm_diagnostics_docstrings(self):
)
assert result.failed == 0, f"Doctest failed: {result.failed} failures"

@pytest.mark.skip_if_max_rank_greater_than(1)
@pytest.mark.parametrize("size", pytest.prob_size)
def test_verbose_comm(self, size):
start_verbose_comm()
ak.zeros(size)
stop_verbose_comm()

@pytest.mark.skip_if_max_rank_greater_than(1)
@pytest.mark.parametrize("op", diagnostic_stats_functions)
@pytest.mark.parametrize("size", pytest.prob_size)
def test_comm_diagnostics_single_locale(self, op, size):
Expand All @@ -76,7 +73,6 @@ def test_comm_diagnostics_single_locale(self, op, size):
reset_comm_diagnostics()
stop_comm_diagnostics()

@pytest.mark.skip_if_max_rank_greater_than(1)
@pytest.mark.skip_if_nl_less_than(2)
@pytest.mark.parametrize("size", pytest.prob_size)
def test_comm_diagnostics_multi_locale(self, size):
Expand All @@ -93,7 +89,6 @@ def test_comm_diagnostics_multi_locale(self, size):

stop_comm_diagnostics()

@pytest.mark.skip_if_max_rank_greater_than(1)
def test_get_comm_diagnostics(self):
start_comm_diagnostics()

Expand Down