Skip to content

Conversation

@e-kayrakli
Copy link
Contributor

Based on #5021, and should be merged after that.

This PR changes benchmarks to use numNodes config instead of numLocales for properly sizing input data.

Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider printing both numNodes and numLocales for debugging purposes.

If you do this, should should do it in all benchmarks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For nightly runs: we have a separate config for co-locale and no-co-locale runs. So, it'd be very easy to know what a particular result is from. Running manually, you already have more control over number of (co-)locales, so it feels less important there.

I do agree that more information printed out from tests is better in general, though. Probably a more principled way is to have a helper printConfigInfo of sorts that are printed out by tests/benchmarks, or by pytest at the beginning of each benchmark.

That's my reasoning to not take this suggestion. Do you want to push more for it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its a quick change that provides value, when reading the logs without knowing how the server was run you can easily tell what is being measured.

I agree a more principled way to print this information is in order, but that shouldn't stop us from making incremental improvements.

That's my reasoning to not take this suggestion. Do you want to push more for it?

I fear if the improvement is not made now, it will never be made :). I won't push super hard for it, but I do think you should make that change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. I will do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants