Closes #4990: streamline ak.array #5019
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpotts
force-pushed
the
5008_Upgrade_to_typeguard_2.11.0_pt2
branch
from
f8a6a74 to
94e89a4
Compare
ajpotts
force-pushed
the
5008_Upgrade_to_typeguard_2.11.0_pt2
branch
from
94e89a4 to
b5c4b8e
Compare
ajpotts
commented
Oct 28, 2025
| max_bits: int = ..., | ||
| ) -> Union[pdarray, Strings]: ... | ||
|
|
||
|
|
Contributor
Author
There was a problem hiding this comment.
Consider breaking the None case out more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
ak.arrayfunction to streamline the logic and improve type checking. It also adds additional unit tests.Closes #4990: streamline ak.array