Clean up internal LLM API #484
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eb8680
force-pushed
the
eb-llm-message-ops
branch
from
061a342 to
fa62848
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring PR reorganizes the internals of
handlers.llmaround four newOperations, each of which (call_assistant,call_user,call_system,call_tool) is responsible for constructing allMessages for onerole("assistant", "user", "system", "tool") in the completions API.It also avoids the anti-pattern of handling
Template.__apply__, except as a temporary expedient inRetryLLMHandler, and includes some general code cleanup ofcompletions.py.I'm putting it up as a draft for discussion, since I haven't finished getting tests to pass and there are still some outstanding design questions, particularly around the desired semantics of failure and repetition.