Add type inference module for embedding polymorphic types #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onicalize more robust
jfeser
requested changes
Aug 12, 2025
jfeser
approved these changes
Aug 13, 2025
Contributor
jfeser
left a comment
jfeser
left a comment
There was a problem hiding this comment.
Looks good to me once lint & tests pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a standalone module
effectful.internals.unificationfor performing unification-based type inference on a subset of Python's generic types, particularly those available as abstract interfaces incollections.abc.The main purpose is to enable a followup PR generalizing the type-directed embedding of
Terms implemented indefdatato support polymorphic functions and nested collections, addressing #277. It should also unblock #289.