Fix broadcasting in discretizer's Dirac-observation branch#71
Merged
Fix broadcasting in discretizer's Dirac-observation branch#71
Conversation
…ficient inference
…zer + dirac observation assumptions
DanWaxman
requested changes
Feb 6, 2026
Collaborator
DanWaxman
left a comment
DanWaxman
left a comment
There was a problem hiding this comment.
It's great to see such a speedup! I think some naming conventions and duplicate code may be confusing, though.
mattlevine22
commented
Feb 6, 2026
Collaborator
Author
mattlevine22
left a comment
mattlevine22
left a comment
There was a problem hiding this comment.
should be ready
DanWaxman
approved these changes
Feb 6, 2026
Collaborator
DanWaxman
left a comment
DanWaxman
left a comment
There was a problem hiding this comment.
This looks good to me!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patches #70.
May interact with batching choices in #63.