Fix Flutter tests: remove codegen dependency for test compilation

[beastoin]

Summary

• Extract globalNavigatorKey from MyApp into app_globals.dart — 24 files that imported main.dart just for MyApp.navigatorKey now import the lightweight app_globals.dart instead
• Remove dev_env.dart import from env.dart — breaks the transitive codegen chain so tests compile without build_runner
• Fix 3 pre-existing env_test.dart failures — isUsingStagingApi tests expected true when stagingApiUrl was null, but the implementation explicitly requires it to be configured
• Simplify test.sh — runs all tests via flutter test instead of listing 9 specific files (was missing 9 of 18 test files)
• Replace broken widget_test.dart — the default Flutter template test constructed MyApp() directly, requiring full codegen

Before

flutter test → 12 compilation errors (Undefined name '_ProdEnv', '_DevEnv')
test.sh → runs 9 of 18 test files, 3 pre-existing assertion failures

After

flutter test → 183 tests, all passed (zero codegen dependency)
test.sh → runs all 18 test files, all pass

Test plan

• flutter test passes with zero failures on a fresh worktree (no .g.dart files, no .env files)
• test.sh still works (codegen bootstrap + full test run)
• All 183 tests pass
• MyApp.navigatorKey still works in main.dart (delegates to globalNavigatorKey)

Fixes #5935

🤖 Generated with Claude Code

[greptile-apps]

Greptile Summary

This PR eliminates the transitive codegen dependency that prevented flutter test from compiling on a clean checkout by introducing app_globals.dart, tightening Env.init(), and replacing the stale template widget test with a minimal smoke test.

Key changes:

• app_globals.dart: Extracts globalNavigatorKey out of main.dart so the 24 files that needed the navigator key can avoid importing main.dart's heavy codegen chain (firebase_options_*.dart, envied-generated classes). MyApp.navigatorKey now delegates to it via a getter, preserving backward compatibility across the whole codebase.
• env/env.dart: Removes the import 'package:omi/env/dev_env.dart' that dragged _DevEnv (a codegen class) into every indirect importer; Env.init() now requires an explicit EnvFields argument (all existing call-sites already pass one).
• test.sh: Collapses 9 hard-coded file paths into a single flutter test, ensuring all 18 test files run.
• env_test.dart: Updates three isUsingStagingApi tests to match the existing implementation's behaviour (staging banner requires STAGING_API_URL to be explicitly configured). The removed tests expected isTrue against a null stub which was never reachable by the new implementation.
• test_env.dart: Adds a public TestEnv stub — currently unused by any test file (see inline comment).
• widget_test.dart: Replaces the wrong Flutter template counter-app test with a trivial MaterialApp smoke test that compiles without codegen.

Confidence Score: 5/5

• Safe to merge — all runtime behaviour is preserved and the refactor is mechanical import-swap across 24 files.
• The core change (extract globalNavigatorKey, remove codegen import from env.dart) is a clean, well-scoped refactor with no logic changes at runtime. MyApp.navigatorKey still works identically via the delegating getter. The only open items are two P2 style suggestions: test_env.dart is unused dead code, and isUsingStagingApi has no positive-case test coverage. Neither affects production correctness or reliability.
• app/test/test_env.dart (unused) and app/test/unit/env_test.dart (missing positive coverage for isUsingStagingApi)

Important Files Changed

Filename	Overview
app/lib/app_globals.dart	New file that extracts globalNavigatorKey from MyApp to break the transitive import chain on main.dart — clean, minimal, well-commented.
app/lib/env/env.dart	Removes dev_env.dart import and tightens init() to require a parameter, breaking the transitive codegen chain. All existing callers already pass a parameter so no breakage.
app/lib/main.dart	Imports app_globals.dart and converts MyApp.navigatorKey from a static final field to a static get delegating to globalNavigatorKey, preserving full backward compatibility.
app/test/test_env.dart	Introduces a public TestEnv stub, but it is not imported or used by any test file in the PR — dead code, though harmless.
app/test/unit/env_test.dart	Updates tests to match the already-changed isUsingStagingApi implementation (requires explicit stagingApiUrl). Removes all three tests that expected isTrue, leaving no coverage for the true code-path of isUsingStagingApi.
app/test/widget_test.dart	Replaces the stale Flutter template counter test (wrong for this app) with a minimal MaterialApp smoke test that compiles without codegen.
app/test.sh	Simplified from listing 9 specific test files to a single flutter test, now running all 18 test files automatically.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["main.dart\n(Env.init, MyApp)"] -->|imports| B["app_globals.dart\nglobalNavigatorKey"]
    A -->|imports| C["env/dev_env.dart\n(codegen)"]
    A -->|imports| D["env/prod_env.dart\n(codegen)"]

    E["providers/*.dart\nservices/*.dart\nutils/*.dart"] -->|Before: imported main.dart| A
    E -->|After: import app_globals.dart| B

    F["test files"] -->|Before: imported main.dart → codegen chain| A
    F -->|After: import app_globals.dart only| B

    G["env.dart\ninit(EnvFields)"] -->|Before: default to DevEnv| C
    G -->|After: required param, no import| H["No codegen dependency"]

    style B fill:#d4edda,stroke:#28a745
    style H fill:#d4edda,stroke:#28a745
    style C fill:#fff3cd,stroke:#ffc107
    style D fill:#fff3cd,stroke:#ffc107

Loading

_{Reviews (1): Last reviewed commit: "Update pubspec.lock with transitive depe..." | Re-trigger Greptile}

[greptile-apps]

TestEnv is never imported or used

test_env.dart adds a public TestEnv stub, but no test file in the repository imports it. env_test.dart defines its own private _TestEnvFields, and capture_provider_test.dart does not use Env at all.

If the intent is to provide a shared stub for future tests, the file is fine to keep — but it should be imported at least by one test (env_test.dart could replace its inline _TestEnvFields with it). Otherwise this is dead code that can be removed to keep the test/ directory tidy.

[greptile-apps]

No positive (isTrue) coverage for isUsingStagingApi

All three removed tests tested the true-returning path. The updated test group now only verifies that isUsingStagingApi returns false in three different ways, leaving the true branch (_normalizeUrl(effective) == _normalizeUrl(configuredStagingUrl)) and the URL-normalisation logic (case folding, trailing-slash stripping) completely uncovered.

Consider adding a variant of _TestEnvFields with an explicit stagingApiUrl:

class _StagingTestEnvFields extends _TestEnvFields {
  @override
  String? get stagingApiUrl => 'https://api.omiapi.com/';
}

and then exercising the cases that were previously tested:

test('true when override matches explicitly configured stagingApiUrl', () {
  // Uses a separate Env instance — or exercise via a helper
  // that accepts an EnvFields to call _normalizeUrl comparison directly
});

This is especially useful because the _normalizeUrl helper (case-insensitive, trailing-slash trimming) is still present and still needs to be exercised to catch regressions.

[beastoin]

lgtm