Skip to content

Conversation

@krushnarout
Copy link
Member

always display speaker names instead of clicking to view

IMG_1678

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the transcript widget to always display speaker names for non-user messages, which aligns with the stated goal. While the change is functionally correct, it introduces a significant maintainability issue and an undocumented change in user experience. The state variable _showSpeakerNames and its toggle function are now misleadingly named, as they now control the visibility of timestamps and STT provider information, not speaker names. Consequently, tapping a speaker's avatar now unintuitively toggles this extra information. I've added a comment to highlight this and recommend a refactoring for improved code clarity and a more predictable user interface.

@mdmohsin7
Copy link
Member

does it show the name of the user as well? (if the segment is assigned to the user)

@krushnarout
Copy link
Member Author

does it show the name of the user as well? (if the segment is assigned to the user)

@mdmohsin7 Aarav told to not show user's name, so the current version is better.
also made clicking on the profile opens the edit dialog, and the timestamp will ve always visible

@mdmohsin7
Copy link
Member

@mdmohsin7 Aarav told to not show user's name, so the current version is better. also made clicking on the profile opens the edit dialog, and the timestamp will ve always visible

Can the user reassign the segments to someone else which they already assigned to themselves?

@krushnarout
Copy link
Member Author

Can the user reassign the segments to someone else which they already assigned to themselves?

yes, because clicking on profile opens the dialog, so it will work

ScreenRecording_01-07-2026.15-48-09_1.MP4

@mdmohsin7 mdmohsin7 merged commit a3678f8 into main Jan 7, 2026
1 check passed
@mdmohsin7 mdmohsin7 deleted the fix/speaker-name branch January 7, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants