pusher thread doesn't let CPU sleep #3959
Merged
+24
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the pusher thread to prevent high CPU usage from busy-waiting, replacing k_yield() with k_sleep(). While k_yield() is an acceptable mechanism for preventing busy-waiting (as per repository rules), the new k_sleep() logic introduces a critical data loss bug under certain conditions. My review includes a detailed explanation of the issue and a suggested fix to ensure data integrity while maintaining the power-saving improvement.
Contributor
Author
|
The CPU can sleep in idle time now |
Contributor
Author
|
Offline mode: |
Contributor
Author
|
Live mode: |
Contributor
Author
|
Audio sync over BLE: |
Collaborator
|
lgmt @TuEmb |
Collaborator
|
this technique can help devkit/devkit2 too. please create a new ticket |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues #3430 #3151
The
pusherthread was consuming a significant amount of CPU because it was running in a tight super loop, preventing the CPU from entering sleep states. This behavior was a cause of high power consumption.This PR reduces power consumption by approximately 3 mA in both offline and live modes.