-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Openmemory config #3905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Openmemory config #3905
Conversation
- Introduced a new env.template file to guide users in setting up their backend environment. - Included placeholders for essential API keys, database configurations, and optional service integrations. - Provided instructions for self-hosting and local development configurations.
- Added .env.example to .gitignore for better environment management. - Updated package versions in pubspec.lock to reflect recent changes and fixes. - Removed outdated .env.template file from the backend directory and updated README instructions accordingly.
- Added .env.example to .gitignore for improved environment management. - Updated package versions in pubspec.lock to align with recent changes. - Removed outdated .env.template file and updated README instructions accordingly.
- Removed .env.template file and added .env.example to .gitignore for better management. - Updated README instructions to reflect changes in environment setup.
- Updated README to clarify environment setup instructions. - Removed .env.template and ensured .env.example is properly ignored in .gitignore. - Aligned package versions in pubspec.lock with recent updates.
- Updated README to include additional setup details. - Ensured .env.example is properly referenced in documentation. - Made minor adjustments to package versions in pubspec.lock for consistency.
…ctions - Added note on running the project initialization script if 'choco' is not recognized after installation. - Included instructions to refresh the PATH for Chocolatey availability in the current session.
- Added clarification on running the project initialization script if 'choco' is not recognized. - Included steps to refresh the PATH for immediate Chocolatey access.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant amount of documentation and configuration related to 'OpenMemory' and self-hosting capabilities, particularly for Windows environments. It also includes several helper scripts to improve the developer experience for setup and verification. The changes are mostly additions of markdown files and scripts. I've found a minor issue in the .gitignore file that should be addressed for correctness and cross-platform compatibility.
| .cursor\rules\openmemory.mdc | ||
| .cursor\rules\openmemory.mdc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Write-Host "Step 2: Activating virtual environment and upgrading pip..." -ForegroundColor Yellow | ||
| & .\venv\Scripts\activate | ||
| python -m pip install --upgrade pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Activate the venv correctly for PowerShell
This script invokes & .\venv\Scripts\activate, which on Windows PowerShell resolves to the CMD/Bash activation script rather than Activate.ps1. In PowerShell that means the environment changes don’t persist in the current session (the .bat runs in a child cmd.exe), so pip install -r requirements.txt will target the global Python or fail if pip isn’t on PATH. This breaks the script’s promise to set up an isolated backend venv for anyone running it in PowerShell.
Useful? React with 👍 / 👎.
No description provided.