-
Notifications
You must be signed in to change notification settings - Fork 1.3k
share important convo with contacts #3879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new feature to notify users about important (long) conversations and allows them to share a summary via SMS with their contacts. This includes adding contacts permissions, a new dependency for accessing contacts, a new UI for contact selection, and backend logic to trigger these notifications. The changes are extensive and well-implemented for the most part.
My main feedback is on the backend notification sending logic. The new and modified functions for sending data-only FCM messages are inefficient and have regressed in error handling, specifically in removing invalid device tokens. I've suggested refactoring these to use an existing helper function that handles batching and token cleanup correctly.
|
@aaravgarg conflicts, also why does it take so long after clicking share with 1 contact button |
in video or locally? video coz my phone sucks |
|
@mdmohsin7 does this look good? |
yes, pls test once deployed |
Yeah, please let me know when deployed. |
|
Already deployed bro, try the latest testflight |
If convo over 30 mins, send notif to suggest sharing convo with contacts
trim.95379F87-4C7C-480D-B5CF-16AF3DF6E26E.MOV