Skip to content

Conversation

@aaravgarg
Copy link
Collaborator

@aaravgarg aaravgarg commented Dec 23, 2025

If convo over 30 mins, send notif to suggest sharing convo with contacts

trim.95379F87-4C7C-480D-B5CF-16AF3DF6E26E.MOV

@aaravgarg aaravgarg requested a review from mdmohsin7 December 23, 2025 13:33
@aaravgarg aaravgarg marked this pull request as ready for review December 23, 2025 13:33
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new feature to notify users about important (long) conversations and allows them to share a summary via SMS with their contacts. This includes adding contacts permissions, a new dependency for accessing contacts, a new UI for contact selection, and backend logic to trigger these notifications. The changes are extensive and well-implemented for the most part.

My main feedback is on the backend notification sending logic. The new and modified functions for sending data-only FCM messages are inefficient and have regressed in error handling, specifically in removing invalid device tokens. I've suggested refactoring these to use an existing helper function that handles batching and token cleanup correctly.

@aaravgarg aaravgarg changed the title initial commit share important convo with contacts Dec 23, 2025
@aaravgarg aaravgarg linked an issue Dec 25, 2025 that may be closed by this pull request
@mdmohsin7
Copy link
Member

@aaravgarg conflicts, also why does it take so long after clicking share with 1 contact button

@aaravgarg
Copy link
Collaborator Author

@aaravgarg conflicts, also why does it take so long after clicking share with 1 contact button

in video or locally? video coz my phone sucks

@aaravgarg
Copy link
Collaborator Author

@mdmohsin7 does this look good?

@mdmohsin7
Copy link
Member

@mdmohsin7 does this look good?

yes, pls test once deployed

@mdmohsin7 mdmohsin7 merged commit f206965 into main Jan 7, 2026
1 check passed
@mdmohsin7 mdmohsin7 deleted the share-convo-to-contact branch January 7, 2026 08:57
@aaravgarg
Copy link
Collaborator Author

@mdmohsin7 does this look good?

yes, pls test once deployed

Yeah, please let me know when deployed.

@mdmohsin7
Copy link
Member

Already deployed bro, try the latest testflight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sharing conversations

3 participants