Skip to content

Conversation

@ajrice6713
Copy link
Contributor

Don't throw exceptions when there is a success status code but errors in the body

@ajrice6713 ajrice6713 requested review from a team as code owners November 13, 2024 21:51
@ajrice6713
Copy link
Contributor Author

Fixes #83

brianluisgomez
brianluisgomez previously approved these changes Nov 13, 2024
description = doc.Descendants("resultMessage").FirstOrDefault();
}
else
if (code != null && description != null && !string.IsNullOrEmpty(code.Value) && code.Value != "0")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is code != null necessary in this block since the previous check is code == null?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not 😂

@ajrice6713 ajrice6713 merged commit 3861a3a into master Nov 14, 2024
11 checks passed
@ajrice6713 ajrice6713 deleted the SWI-6546 branch November 14, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants