Cut By Mask is always adding +1 pixel to the width and height.#7
Closed
HomogenousMoss wants to merge 1 commit into
Closed
Cut By Mask is always adding +1 pixel to the width and height.#7HomogenousMoss wants to merge 1 commit into
HomogenousMoss wants to merge 1 commit into
Conversation
…idth and height of the output. It's a problem for example if you're trying to do multiples of 8 sizes so that the ksampler doesnt not resize the output to the nearest factor of 8.
|
Hi! I believe I just stumbled across the same issue, only I was 1 minute later with opening a PR #8! However I do believe that the computation in |
Author
|
You're quite possibly right, it was my first time looking at python for comfyui, I just wanted this to work. I looked over your PR and it does seem like it would be a better solution. I'll close mine and hopefully yours get merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing a Cut by Mask, the +1 was always adding one pixel to the width and height of the output. It's a problem for example if you're trying to do multiples of 8 sizes so that the ksampler doesnt not resize the output to the nearest factor of 8.
I have an example thread on reddit about the issue: