Skip to content

Conversation

@vlakoff
Copy link
Contributor

@vlakoff vlakoff commented Nov 16, 2025

As raised in this comment, the following lines are unnecessary and can safely be deleted:

if ($actual !== $expected) {
    $array->getNextSet($query);
}
  • These lines do not exist in the source test logic.
  • They serve no purpose and appear to be leftover code.
  • Removing them improves test clarity and avoids confusion.

As discussed in PR Bacon#208, lines 114–116 in BitArrayTest.php are useless
and appear to be leftover code. They do not exist in the source test
logic and can safely be removed.
@codecov
Copy link

codecov bot commented Nov 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.51%. Comparing base (741e712) to head (08f0c76).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #210   +/-   ##
=========================================
  Coverage     70.51%   70.51%           
  Complexity      993      993           
=========================================
  Files            49       49           
  Lines          3174     3174           
=========================================
  Hits           2238     2238           
  Misses          936      936           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DASPRiD DASPRiD merged commit 80bee1f into Bacon:main Nov 16, 2025
9 checks passed
@vlakoff vlakoff deleted the test/cleanup branch November 16, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants