Skip to content

Conversation

@DASPRiD
Copy link
Member

@DASPRiD DASPRiD commented Nov 15, 2025

No description provided.

@codecov
Copy link

codecov bot commented Nov 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.59%. Comparing base (f9cc1f5) to head (799cefa).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #206   +/-   ##
=========================================
  Coverage     70.59%   70.59%           
  Complexity      995      995           
=========================================
  Files            49       49           
  Lines          3183     3183           
=========================================
  Hits           2247     2247           
  Misses          936      936           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DASPRiD DASPRiD merged commit 762ba02 into main Nov 15, 2025
8 checks passed
vlakoff referenced this pull request in Chris53897/BaconQrCode Nov 15, 2025
add dev spatie/pixelmatch-php
@vlakoff
Copy link
Contributor

vlakoff commented Nov 16, 2025

It seems that you forgot to delete these two files (in the __snapshots__/files subdirectory`):

  • __snapshots__/files/GDLibRenderingTest__testGenericQrCode__1.png
  • __snapshots__/files/GDLibRenderingTest__testDifferentColorsQrCode__1.png

(Thus, Git considered the two identical files in __snapshots__ as added files instead of renamed files. Fortunately, due to Git's deduplication feature, this doesn't actually increase the repository size — only the history looks noisier.)

Edit: submitted #212 about this.

@vlakoff
Copy link
Contributor

vlakoff commented Nov 16, 2025

I was afraid that the addition of Node.js would make the jobs' setup significantly slower (adding a few dozens of seconds), but actually it just adds a handful of seconds, which is great (and impressive). So it's not problematic in practice. Furthermore, it only affects testing and not production.

However, it still adds a setup step for developers, and it's a shame to use a JavaScript implementation for code that is actually quite short: https://github.com/mapbox/pixelmatch/blob/main/index.js (and we could even trim the antialiased() and hasManySiblings() functions, which would bring it below 200 lines, docblocks included).

vlakoff added a commit to vlakoff/BaconQrCode that referenced this pull request Nov 17, 2025
Snapshots were moved from "__snapshots__/files" to "__snapshots" in Bacon#206.
These two files were moved as well, but their original copies remained due to oversight.
vlakoff added a commit to vlakoff/BaconQrCode that referenced this pull request Nov 17, 2025
Snapshots were moved from "__snapshots__/files" to "__snapshots__" in Bacon#206.
These two files were moved as well, but their original copies remained due to oversight.
vlakoff added a commit to vlakoff/BaconQrCode that referenced this pull request Nov 17, 2025
Snapshots were moved from "__snapshots__/files" to "__snapshots__" in Bacon#206.
These two files were moved as well, but their original copies remained due to oversight.
@DASPRiD DASPRiD deleted the fix/imagick-tests branch November 17, 2025 19:59
DASPRiD pushed a commit that referenced this pull request Nov 17, 2025
Snapshots were moved from "__snapshots__/files" to "__snapshots__" in #206.
These two files were moved as well, but their original copies remained due to oversight.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants