Open
Conversation
Collaborator
BhargaviYamanuri
commented
Feb 15, 2024
BhargaviYamanuri
commented
- Created Custom card journey with MVI architecture.
- It will give understanding of how to crate a journey.
- We used modular concept.
# Conflicts: # app/src/main/assets/backbase/config.json # app/src/main/res/navigation/navigation_main.xml
# Conflicts: # accounts-journey/src/main/kotlin/com/backbase/accounts_journey/presentation/accountlist/ui/AccountListFragment.kt # app/src/main/kotlin/com/backbase/golden_sample_app/MainApplication.kt # settings.gradle.kts
# Conflicts: # accounts-journey/src/main/kotlin/com/backbase/accounts_journey/presentation/accountlist/ui/AccountListFragment.kt # accounts-journey/src/main/res/navigation/account_journey_nav_graph.xml # accounts-journey/src/main/res/values/strings.xml # app/build.gradle.kts # app/src/main/kotlin/com/backbase/golden_sample_app/MainApplication.kt # app/src/main/res/navigation/navigation_main.xml # gradle/backbase.versions.toml # settings.gradle.kts
ran detekt
Ran detekt, applied format
Collaborator
|
I checked and merged 2024.09.LTS into this branch. If this is going to be part of the main branch, we need new gradle modules to separate RnD and CS. Now Core-UI module is on the root and use by CS journey. This might be confusing. |
charbelmkh
requested changes
Jun 11, 2025
Collaborator
charbelmkh
left a comment
charbelmkh
left a comment
There was a problem hiding this comment.
Please refer to CONTRIBUTING.md and CATALOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.