Skip to content

Add wrapped-native-texture device-loss restore unit test #1716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bghgary wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add wrapped-native-texture device-loss restore unit test #1716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6fc4910
Add wrapped-native-texture device-loss restore unit test
bghgary May 21, 2026
3c64912
config: increase renderCount for 'Load GUI snippet with unicode' (50 …
bghgary May 22, 2026
20968f8
tests: fail fast when updateWrappedNativeTexture is unavailable
bghgary May 22, 2026
a0cd17f
test: fix GUI snippet flake + add guiIsReady gate to viz runner
bghgary May 22, 2026
8c7af6f
config: sync safe PG version bumps from BJS
bghgary May 22, 2026
f50dd91
ci: retrigger (Win32 runners stuck pending on rerun)
bghgary May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Apps/Playground/Scripts/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@
},
{
"title": "Solid particle system",
"playgroundId": "#WCDZS#92",
"playgroundId": "#WCDZS#531",
"renderCount": 150,
"referenceImage": "sps.png",
"errorRatio": 6.0
Expand Down Expand Up @@ -864,7 +864,7 @@
},
{
"title": "Volumetric Light Scattering Post Process with Morph Targets",
"playgroundId": "#5E318S#5",
"playgroundId": "#5E318S#7",
"excludeFromAutomaticTesting": true,
"reason": "Pixel comparison fails on Linux (large diff)",
"referenceImage": "volumetricLightScatteringMorphTargets.png"
Expand Down Expand Up @@ -2397,13 +2397,13 @@
{
"title": "Load GUI snippet with unicode",
"playgroundId": "#YS93KY#0",
"renderCount": 50,
"replace": "adv.parseFromSnippetAsync(\"#KHPNS9\").then(() => {}), return adv.parseFromSnippetAsync(\"#KHPNS9\").then(() => { return scene; })",
"referenceImage": "loadGuiSnippetWithUnicode.png"
},
{
"title": "Parse GUI json with unicode",
"playgroundId": "#ERVGT5#0",
"renderCount": 50,
"replace": "adv.parseFromURLAsync(\"https://raw.githubusercontent.com/carolhmj/quick-demos/main/assets/gui/guiWithUnicode.json\").then(() => {\n \n }), return adv.parseFromURLAsync(\"https://raw.githubusercontent.com/carolhmj/quick-demos/main/assets/gui/guiWithUnicode.json\").then(() => { return scene; })",
"referenceImage": "parseGuiJsonWithUnicode.png"
},
{
Expand Down Expand Up @@ -4963,7 +4963,7 @@
},
{
"title": "wgsl-in-shadermaterial",
"playgroundId": "#8RU8Q3#157",
"playgroundId": "#8RU8Q3#193",
"renderCount": 30,
"excludeFromAutomaticTesting": true,
"reason": "Requires WebGL2-only feature (not supported by Babylon Native)"
Expand Down
16 changes: 15 additions & 1 deletion Apps/Playground/Scripts/validation_native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,8 +242,22 @@
if (currentScene.activeCamera && currentScene.activeCamera.useAutoRotationBehavior) {
currentScene.activeCamera.useAutoRotationBehavior = false;
}
// Wait for GUI ADTs (e.g. images loaded after parseFromSnippetAsync)
// before counting comparison frames, matching BJS Playwright runner.
var sceneAdts = currentScene.textures.filter(function (t) {
return t.getClassName() === "AdvancedDynamicTexture";
});
var guiSettleFrames = sceneAdts.length > 0 ? 1 : 0;
engine.runRenderLoop(function () {
try {
if (guiSettleFrames > 0) {
currentScene.render();
if (sceneAdts.every(function (adt) { return adt.guiIsReady(); })) {
guiSettleFrames--;
}
return;
}

frameIndex++;

if (captureFrame > 0 && frameIndex === captureFrame && TestUtils.captureNextFrame) {
Expand Down Expand Up @@ -393,7 +407,7 @@
try {
request.onreadystatechange = null;

const scriptToRun = request.responseText.replace(/..\/..\/assets\//g, config.root + "/Assets/");
let scriptToRun = request.responseText.replace(/..\/..\/assets\//g, config.root + "/Assets/");
scriptToRun = scriptToRun.replace(/..\/..\/Assets\//g, config.root + "/Assets/");
scriptToRun = scriptToRun.replace(/\/assets\//g, config.root + "/Assets/");

Expand Down
2 changes: 2 additions & 0 deletions Apps/UnitTests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ set(BABYLONJS_MATERIALS_ASSETS

set(TEST_ASSETS
"JavaScript/dist/tests.externalTexture.msaa.js"
"JavaScript/dist/tests.wrappedNativeTexture.restore.js"
"JavaScript/dist/tests.javaScript.all.js"
"JavaScript/dist/tests.shaderCache.basicScene.js"
"JavaScript/dist/tests.shaders.cross.js")
Expand All @@ -24,6 +25,7 @@ set(SOURCES
"Source/App.cpp"
"Source/Tests.ExternalTexture.cpp"
"Source/Tests.ExternalTexture.Msaa.cpp"
"Source/Tests.WrappedNativeTexture.Restore.cpp"
"Source/Tests.JavaScript.cpp"
"Source/Tests.ShaderCache.cpp"
"Source/Tests.ShaderCompilation.cpp"
Expand Down
Loading
Loading