Skip to content

Fix ExternalTexture_OpenGL throw-stubs to avoid MSVC C4702 under /WX #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkaradzic-microsoft merged 3 commits into from
May 28, 2026
+11 −3
Merged

Fix ExternalTexture_OpenGL throw-stubs to avoid MSVC C4702 under /WX #1703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
067a8a4
Replace OpenGL ExternalTexture throw-stubs with inert default-value s…
bkaradzic-microsoft May 16, 2026
834c99f
Switch C4702 suppression from runtime-behavior change to localized pr…
bkaradzic-microsoft May 18, 2026
90ddc75
PR #1703 review: trim source comment per bghgary
bkaradzic-microsoft May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Plugins/ExternalTexture/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ set(SOURCES

add_library(ExternalTexture ${SOURCES})
warnings_as_errors(ExternalTexture)
if(GRAPHICS_API STREQUAL "OpenGL" AND MSVC)
target_compile_options(ExternalTexture PRIVATE /wd4702)
endif()

target_include_directories(ExternalTexture
PUBLIC "Include")
Expand Down
11 changes: 11 additions & 0 deletions Plugins/ExternalTexture/Source/ExternalTexture_OpenGL.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@

namespace Babylon::Plugins
{
// Suppress C4702 for the shared dispatcher - Impl stubs always throw,
// making the dispatcher's post-call code unreachable.
class ExternalTexture::Impl final : public ImplBase
{
public:
Expand All @@ -36,4 +38,13 @@ namespace Babylon::Plugins
};
}

#if defined(_MSC_VER)
#pragma warning(push)
#pragma warning(disable : 4702) // unreachable code (Impl stubs always throw)
#endif

#include "ExternalTexture_Shared.h"

#if defined(_MSC_VER)
#pragma warning(pop)
#endif