Skip to content

BRN Sourcetree #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CedricGuillemet merged 2 commits into from
Jan 12, 2026
Merged

BRN Sourcetree #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab708dc
BRN Sourcetree
CedricGuillemet Jun 10, 2025
66520bf
Merge branch 'main' of https://github.com/BabylonJS/AndroidExtensions…
CedricGuillemet Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ FetchContent_MakeAvailable(CMakeExtensions)

project(AndroidExtensions)

Copy link

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flag BABYLON_NATIVE_BUILD_SOURCETREE is not documented anywhere in the codebase. Consider adding documentation or comments explaining what this flag is for, when it should be used, and what platforms are supported when it's enabled. This will help other developers understand the purpose and proper usage of this build configuration.

Suggested change
# BABYLON_NATIVE_BUILD_SOURCETREE is an internal flag used when this project is
# built as part of the Babylon Native source tree (for example, via the parent
# Babylon Native CMake build). In that scenario, the outer build system controls
# the target platforms and toolchains, so we allow configuration even when the
# CMake ANDROID variable is not set.
#
# When building AndroidExtensions standalone (i.e., not from within the Babylon
# Native source tree), this flag should normally remain unset, and the project is
# intended to build only for Android. In that case, we enforce the Android-only
# restriction with the check below.

Copilot uses AI. Check for mistakes.
if(NOT ANDROID)
if(NOT ANDROID AND NOT BABYLON_NATIVE_BUILD_SOURCETREE)
message(FATAL_ERROR "This project can only build for Android")
endif()

Expand Down