refactor: remove obsolete OptiX PTX scratch files and stale sysrap test runners#343
Open
plexoos wants to merge 3 commits into
Open
refactor: remove obsolete OptiX PTX scratch files and stale sysrap test runners#343plexoos wants to merge 3 commits into
plexoos wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an unused OptiX debug/probe CUDA source (Check.cu) and simplifies the CSGOptiX CMake PTX build setup now that CSGOptiX7.cu is the only remaining OptiX CUDA source.
Changes:
- Drop
CSGOptiX/Check.cufrom the repository. - Replace the
OPTIX_SOURCESlist/foreach PTX generation with a singleOPTIX_SOURCEPTX object-library target. - Update the install rule to reference the PTX object target via
${OPTIX_SOURCE}.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| CSGOptiX/CMakeLists.txt | Simplifies PTX object target creation and installation now that only one OptiX CUDA source remains. |
| CSGOptiX/Check.cu | Removes an obsolete debug/probe CUDA source. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| set(SOURCES) | ||
| set(OPTIX_SOURCES) | ||
| set(OPTIX_SOURCE CSGOptiX7.cu) |
Dropped the unused Check.cu debug/probe source from CSGOptiX and simplified the CMake PTX setup now that CSGOptiX7.cu is the only remaining OptiX source.
Dropped stale SOPTIX module/pipeline test sources and shell wrappers and removed the unused go.sh/tests.txt runner path and clean up leftover references.
plexoos
force-pushed
the
remove-outdated-check-ptx
branch
from
5fd50c4 to
a45c567
Compare
plexoos
changed the title
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes outdated OptiX/PTX scratch code and related stale test artifacts.
CSGOptiX cleanup
CSGOptiX/Check.cudebug/probe sourceCSGOptiX/CMakeLists.txtnow thatCSGOptiX7.cuis the only remaining OptiX PTX sourcesysrap test cleanup
SOPTIX_Module_test.{cc,sh}andSOPTIX_Pipeline_test.{cc,sh}filessysrap/tests/go.shrunner and itstests.txtmanifestsysrap/SOPTIX.rstandsysrap/SGLFW_Evt.hWhy
Check.cuwas an old standalone compiler/debug check and is no longer part of the active OptiX path.The removed
sysraptest files were stale, not wired into the current CMake test flow, and still referenced outdated PTX naming/path conventions. Existing OptiX integration paths already exercise module/pipeline creation more realistically through current render/simulate flows.