Skip to content

fix: Activity API 삭제#2185

Merged
Soundbar91 merged 3 commits intodevelopfrom
fix/delete-activity-api
Apr 1, 2026
Merged

fix: Activity API 삭제#2185
Soundbar91 merged 3 commits intodevelopfrom
fix/delete-activity-api

Conversation

@Soundbar91
Copy link
Copy Markdown
Collaborator

@Soundbar91 Soundbar91 commented Mar 18, 2026

🔍 개요


🚀 주요 변경 내용


💬 참고 사항


✅ Checklist (완료 조건)

  • 코드 스타일 가이드 준수
  • 테스트 코드 포함됨
  • Reviewers / Assignees / Labels 지정 완료
  • 보안 및 민감 정보 검증 (API 키, 환경 변수, 개인정보 등)

Summary by CodeRabbit

Release Notes

  • Revert
    • Removed the activities API endpoint that allowed querying BCSD Lab activity records. This functionality is no longer available through the service.

@Soundbar91 Soundbar91 self-assigned this Mar 18, 2026
@github-actions github-actions bot added the 버그 정상적으로 동작하지 않는 문제상황입니다. label Mar 18, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3122b923-9f88-4eb3-9de0-f51f3eda50f9

📥 Commits

Reviewing files that changed from the base of the PR and between e41a0cf and 4000f06.

📒 Files selected for processing (9)
  • src/main/java/in/koreatech/koin/domain/activity/controller/ActivityApi.java
  • src/main/java/in/koreatech/koin/domain/activity/controller/ActivityController.java
  • src/main/java/in/koreatech/koin/domain/activity/dto/ActivitiesResponse.java
  • src/main/java/in/koreatech/koin/domain/activity/dto/ActivityResponse.java
  • src/main/java/in/koreatech/koin/domain/activity/model/Activity.java
  • src/main/java/in/koreatech/koin/domain/activity/repository/ActivityRepository.java
  • src/main/java/in/koreatech/koin/domain/activity/service/ActivityService.java
  • src/test/java/in/koreatech/koin/acceptance/domain/ActivityApiTest.java
  • src/test/java/in/koreatech/koin/acceptance/fixture/ActivityAcceptanceFixture.java
💤 Files with no reviewable changes (9)
  • src/main/java/in/koreatech/koin/domain/activity/dto/ActivitiesResponse.java
  • src/main/java/in/koreatech/koin/domain/activity/controller/ActivityApi.java
  • src/main/java/in/koreatech/koin/domain/activity/service/ActivityService.java
  • src/test/java/in/koreatech/koin/acceptance/domain/ActivityApiTest.java
  • src/main/java/in/koreatech/koin/domain/activity/controller/ActivityController.java
  • src/main/java/in/koreatech/koin/domain/activity/repository/ActivityRepository.java
  • src/main/java/in/koreatech/koin/domain/activity/model/Activity.java
  • src/main/java/in/koreatech/koin/domain/activity/dto/ActivityResponse.java
  • src/test/java/in/koreatech/koin/acceptance/fixture/ActivityAcceptanceFixture.java

📝 Walkthrough

Walkthrough

The entire Activity feature—including the public API endpoint, controller, service layer, data models, repository, DTOs, and associated acceptance tests—has been removed from the codebase. This eliminates all functionality for retrieving BCSD Lab activity records via the GET /activities endpoint.

Changes

Cohort / File(s) Summary
API & Controller Layer
src/main/java/in/koreatech/koin/domain/activity/controller/ActivityApi.java, src/main/java/in/koreatech/koin/domain/activity/controller/ActivityController.java
Removed ActivityApi interface (OpenAPI contract for /activities endpoint) and ActivityController implementation (Spring REST controller delegating to ActivityService).
DTO Layer
src/main/java/in/koreatech/koin/domain/activity/dto/ActivitiesResponse.java, src/main/java/in/koreatech/koin/domain/activity/dto/ActivityResponse.java
Removed ActivitiesResponse (wrapper record for activity list) and ActivityResponse (DTO with factory method mapping Activity entities to responses).
Model & Repository Layer
src/main/java/in/koreatech/koin/domain/activity/model/Activity.java, src/main/java/in/koreatech/koin/domain/activity/repository/ActivityRepository.java
Removed Activity JPA entity and ActivityRepository Spring Data interface with query methods (getActivitiesByYear, findAllByIsDeleted).
Service Layer
src/main/java/in/koreatech/koin/domain/activity/service/ActivityService.java
Removed ActivityService business logic, including getActivities() method and image URL parsing helper.
Test & Fixture Layer
src/test/java/in/koreatech/koin/acceptance/domain/ActivityApiTest.java, src/test/java/in/koreatech/koin/acceptance/fixture/ActivityAcceptanceFixture.java
Removed acceptance tests for activity retrieval (with and without year parameter) and fixture builder for creating test Activity instances.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 A hop through the code, a cleanup so bright,
Activities removed—no more API in sight!
Fixtures and tests bid farewell with cheer,
Spring Data and services vanish from here!
Simpler the codebase, cleaner and lean—
Off goes the feature, once proud, now unseen! 🌿

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: Activity API 삭제' clearly and accurately describes the main change in the pull request, which is the deletion/removal of the Activity API and all associated components.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/delete-activity-api
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 18, 2026

Unit Test Results

689 tests   686 ✔️  1m 24s ⏱️
168 suites      3 💤
168 files        0

Results for commit 9f92599.

♻️ This comment has been updated with latest results.

@Soundbar91 Soundbar91 marked this pull request as draft March 18, 2026 04:26
@kih1015 kih1015 self-requested a review March 30, 2026 12:29
@Soundbar91 Soundbar91 marked this pull request as ready for review April 1, 2026 05:43
@Soundbar91 Soundbar91 merged commit 5479530 into develop Apr 1, 2026
6 checks passed
@Soundbar91 Soundbar91 deleted the fix/delete-activity-api branch April 1, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

버그 정상적으로 동작하지 않는 문제상황입니다.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants