Skip to content

Conversation

@domily-jo
Copy link

No description provided.

Copy link
Contributor

@kongwoojin kongwoojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.
코멘트 확인 해주세요

import android.widget.Toast
import androidx.recyclerview.widget.RecyclerView

class MusicAdapter(private val musicList: List<Music>) :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

클래스 이름과 파일 이름을 동일하게 수정해주세요

android:theme="@style/Theme.BCSD_Android_20251"
tools:targetApi="31">
<activity
android:name=".Adapter"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adapter와 data class는 activity가 아니고, androidmanifest에 선언 하지 않아야 합니다

app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" />
<androidx.recyclerview.widget.RecyclerView
android:id="@+id/recyclerView"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xml naming convention은 snake_case입니다

android:padding="12dp">

<TextView
android:id="@+id/text_list_Title"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snake_case에서는 대문자를 사용하지 않습니다

@@ -1,3 +1,11 @@
<resources>
<string name="app_name">BCSD_Android_2025-1</string>
<string name="play">재생</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants