temurin-jre: correct extract_dir in autoupdate#2
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the autoupdate template in bucket/temurin-jre.json by removing the -jre suffix from the extract_dir property. While this change correctly handles future updates, the manifest remains broken for the current version because the top-level extract_dir still contains the incorrect suffix and needs to be updated. Furthermore, a similar issue was identified in temurin-lts-jre.json that should also be addressed.
| "find": "^([a-fA-F0-9]+)\\s" | ||
| }, | ||
| "extract_dir": "$matchTag-jre" | ||
| "extract_dir": "$matchTag" |
There was a problem hiding this comment.
The fix for the autoupdate template is correct. However, the manifest remains broken for the current version because the top-level extract_dir (line 12) still contains the incorrect -jre suffix. It should be updated to jdk-26+35 to ensure the manifest works for users installing the current version. Additionally, temurin-lts-jre.json (visible in the repository context) appears to have the same incorrect $matchTag-jre pattern in its autoupdate section and should also be corrected to ensure future updates work correctly for that manifest as well.
📝 WalkthroughWalkthroughUpdated two Temurin JRE manifests: one changed extraction target from a Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
✅ Actions performedReview triggered.
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. temurin-jre
|
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with temurin-jre
temurin-lts-jre
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. temurin-jre
temurin-lts-jre
|
Summary
Fixes the extraction directory mismatch bug that causes temurin-jre updates to fail.
Problem
The autoupdate formula uses
$matchTag-jrewhich adds a-jresuffix to the expected extraction directory. However, the actual extracted directory from the Temurin JRE ZIP files is justjdk-{tag}WITHOUT the-jresuffix.Example:
jdk-24.0.2+12jdk-24.0.2+12-jrejdk-24.0.2+12This caused issue ScoopInstaller#552 where updating temurin-jre from 24.0.1-9 to 24.0.2-12 failed with "Could not find 'jdk-24.0.2+12-jre'".
Fix
Change autoupdate.extract_dir from
$matchTag-jreto$matchTag.Closes ScoopInstaller#552
Summary by CodeRabbit