Skip to content

Remove Mail MCP dependency from S360 reporter skill#430

Closed
shahzaibj wants to merge 10 commits intomasterfrom
shahzaibj/s360-remove-mail-mcp
Closed

Remove Mail MCP dependency from S360 reporter skill#430
shahzaibj wants to merge 10 commits intomasterfrom
shahzaibj/s360-remove-mail-mcp

Conversation

@shahzaibj
Copy link
Copy Markdown
Contributor

Summary

Removes the Mail MCP dependency from the S360 reporter skill and agency.toml.

Why

  1. Outlook draft creation - The generated HTML report (~65KB) consistently exceeded API limits, resulting in a useless placeholder draft. Users copy/paste from the browser preview instead.
  2. Mail Search fallback (Step 3a Method 3) - A fallback-of-a-fallback for finding last week's report. Replaced with an ask_user prompt, which is simpler and more reliable.

Changes

  • agency.toml: Removed mail MCP entry
  • SKILL.md: Removed Mail MCP from prerequisites, simplified Step 6 (no more draft creation), replaced Mail Search fallback with ask_user, removed Mail MCP edge case

Fallback chain for last week's report

Before: User paste -> WorkIQ -> Mail Search -> skip
After: User paste -> WorkIQ -> Ask user again -> skip

shahzaibj and others added 10 commits April 1, 2026 16:04
…h email draft

- Add committed Node.js report generator (generate-report.js) that reads JSON
  input and produces Outlook-compatible HTML reports
- Auto-create PBIs without user confirmation, default area path and computed iteration
- Add Step 4b to auto-close resolved PBIs (transition to Done)
- Scope WorkIQ email query to last 7 days for freshness
- Add Graph API email draft (POST /v1.0/me/messages) with file fallback
- Add Quick Mode for CLI-only summary without full report
- Filter person-targeted items to team members via org chart
- Update edge cases for new features

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
When ActionOwnerAlias is empty, omit System.AssignedTo from the PBI
instead of falling back to the S360 AssignedTo field (which defaults
to the manager). Show 'Unassigned' in the report for manual triage.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Root cause of bad report quality:
1. Program headings used raw API codes (ADFunGlobal, ADFunCompliance)
   instead of ProgramDisplayName. Added explicit priority-ordered
   extraction: ProgramDisplayName > campaign > TeamName > filter (mapped)
2. Missing titles had no fallback. Added fallback to WaveDisplayName
3. Dedup was too weak for multi-target KPIs (CFS endpoints). Added
   fuzzy dedup by KpiId with merge-and-count logic.

Also: owner name now falls back to nameMap from Step 0 when
S360Dimensions.ActionOwner is empty.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Remove mail MCP from agency.toml (no longer needed)
- Remove Outlook draft creation from Step 6 (user copies from browser preview instead)
- Replace Mail Search fallback in Step 3a with ask_user prompt
- Remove Mail MCP edge case entry
- Update SKILL.md prerequisites to reflect removal

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@shahzaibj shahzaibj requested a review from a team as a code owner May 9, 2026 18:16
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 9, 2026

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

@shahzaibj shahzaibj closed this May 9, 2026
@shahzaibj shahzaibj deleted the shahzaibj/s360-remove-mail-mcp branch May 9, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant