Update condition logic in competitive-test.yml#1158
Open
wolfgang-desalvador wants to merge 2 commits into
Open
Update condition logic in competitive-test.yml#1158wolfgang-desalvador wants to merge 2 commits into
wolfgang-desalvador wants to merge 2 commits into
Conversation
wolfgang-desalvador
requested review from
alyssa1303,
anson627,
liyu-ma,
sumanthreddy29,
vittoriasalim,
wonderyl and
xinWeiWei24
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the jobs/competitive-test.yml Azure Pipelines job template to improve cancellation behavior and prevent the job from starting when the run is already canceled.
Changes:
- Added a
cancellation_timeout_in_minutesparameter and wired it to the job’scancelTimeoutInMinutes. - Updated the job
conditionto includenot(canceled())in addition to existing manual/scheduled-on-main gating.
vittoriasalim
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
jobs/competitive-test.ymlworkflow to improve job cancellation handling and make job conditions more robust. The main changes introduce a configurable cancellation timeout and ensure jobs do not run if already canceled.Job execution and cancellation improvements:
cancellation_timeout_in_minutesparameter to allow configuring how long to wait before force-canceling a job, and set its default value.cancelTimeoutInMinutesparameter and changed the job'sconditionto ensure it does not run if already canceled.