Skip to content

Conversation

@LongOddCode
Copy link
Contributor

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Azure Active Directory (AAD) authentication flow to dynamically discover the authorization endpoint using OpenID Connect metadata instead of hardcoding it. This ensures compatibility with different AAD tenant configurations that may have varying endpoint URLs.

  • Introduces a new OpenIdHelper class to handle OpenID Connect discovery
  • Updates AAD authentication to use discovered authorization endpoint
  • Adds the openid-client dependency for OpenID Connect operations

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/msha/auth/routes/auth-login-provider-custom.ts Updates AAD case to use dynamically discovered authorization endpoint
src/core/utils/openidHelper.ts New utility class for OpenID Connect discovery operations
package.json Adds openid-client dependency and reorders name/version fields

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@LongOddCode LongOddCode force-pushed the developer/long/issuer branch from 572effd to 209f12e Compare September 4, 2025 08:39
@LongOddCode LongOddCode merged commit 2102e1c into main Sep 5, 2025
18 checks passed
@LongOddCode LongOddCode deleted the developer/long/issuer branch September 5, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants