Fix NodeExpandVolume#493
Open
ArielYehezkely wants to merge 3 commits into
Open
Conversation
ArielYehezkely
commented
May 27, 2026
- Fix NodeExpandVolume to continue to actually call lvextend when the requested capacity is larger than the current PV capacity to enable exapnsion.
- Advertise PluginCapability_VolumeExpansion_ONLINE so the external-resizer sidecar drives NodeExpandVolume per CSI spec.
- After a successful NodeExpandVolume, patch pv.Spec.CSI.VolumeAttributes[CapacityParam] with the new size via a client.MergeFrom patch so failover re-provisioning recreates the LV at the expanded size.
- Add unit tests and e2e tests for expanding PV.
Contributor
|
Thanks for adding so many tests and thanks for thinking too of the case where we need to rehydrate the expanded PV. Can you also change controllerExpansion to true in |
jmclong
reviewed
May 27, 2026
ddfc418 to
26bc072
Compare
26bc072 to
4b91284
Compare
Author
|
@jmclong The E2E tests revealed a problem that might require a wider change - the capacityParam is an immutable field which cannot be patched, this mean that re-provisioning after expansion will create the PV with the original size from creation time, I don't know if this is a blocker for the current change. |
jmclong
reviewed
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.