build(deps): bump https://github.com/golangci/golangci-lint from v2.11.4 to 2.12.1 in the pre-commit group

[dependabot]

Bumps the pre-commit group with 1 update: https://github.com/golangci/golangci-lint.

Updates https://github.com/golangci/golangci-lint from v2.11.4 to 2.12.1

Release notes

Sourced from https://github.com/golangci/golangci-lint's releases.

v2.12.1

golangci-lint is a free and open-source project built by volunteers.

If you value it, consider supporting us, the maintainers and linter authors.

We appreciate it! ❤️

For key updates, see the changelog.

Changelog

[!IMPORTANT] If you are using the install script from the master branch: https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh This branch is not used anymore, we are using main.

We recommend using https://golangci-lint.run/install.sh as URL to install golangci-lint.

https://golangci-lint.run/docs/welcome/install/local/#binaries

• 35b2189782a6a059489289257e6523550167cb64 fix: install.sh script (#6539)
• 3a006ab284f52a5aac0a7daa77ae683e43fb7b69 gomodguard: fix panic with migration suggestion (#6542)

Changelog

Sourced from https://github.com/golangci/golangci-lint's changelog.

Follow the news and releases on Mastodon and on Bluesky.

golangci-lint is a free and open-source project built by volunteers.

If you value it, consider supporting us, we appreciate it!

v1.64.8

Released on 2025-03-17

• Detects use of configuration files from golangci-lint v2

v1.64.7

Released on 2025-03-11

1. Linters bug fixes
   • depguard: from 2.2.0 to 2.2.1
   • dupl: from 3e9179ac440a to f665c8d69b32
   • gosec: from 2.22.1 to 2.22.2
   • staticcheck: from 0.6.0 to 0.6.1
2. Documentation
   • Add GitLab documentation

v1.64.6

Released on 2025-03-02

1. Linters bug fixes
   • asciicheck: from 0.4.0 to 0.4.1
   • contextcheck: from 1.1.5 to 1.1.6
   • errcheck: from 1.8.0 to 1.9.0
   • exptostd: from 0.4.1 to 0.4.2
   • ginkgolinter: from 0.19.0 to 0.19.1
   • go-exhaustruct: from 3.3.0 to 3.3.1
   • gocheckcompilerdirectives: from 1.2.1 to 1.3.0
   • godot: from 1.4.20 to 1.5.0
   • perfsprint: from 0.8.1 to 0.8.2
   • revive: from 1.6.1 to 1.7.0
   • tagalign: from 1.4.1 to 1.4.2

v1.64.5

Released on 2025-02-13

1. Bug fixes

... (truncated)

Commits

• 9aa24e9 chore: prepare release
• 3a006ab gomodguard: fix panic with migration suggestion (#6542)
• 35b2189 fix: install.sh script (#6539)
• 6349bbc docs: update GitHub Action assets (#6538)
• 7761527 chore: prepare release
• 8116fb5 build(deps): bump github.com/bombsimon/wsl/v5 from 5.6.0 to 5.8.0 (#6536)
• eec5c47 build(deps): bump github.com/Masterminds/semver/v3 from 3.4.0 to 3.5.0 (#6535)
• c670072 build(deps): bump github.com/alecthomas/chroma/v2 from 2.23.1 to 2.24.1 (#6534)
• 80ad1dc feat: embed the JSON schema in the binary (#6533)
• 8589d80 build(deps): bump github.com/securego/gosec/v2 from 2.25.0 to 2.26.1 (#6532)
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
• @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
• @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
• @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
• @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

[jmclong]

@copilot can you update the pr to fix all of the new linter issues. Actually fix this issue (dont suppress)

[Copilot]

@copilot can you update the pr to fix all of the new linter issues. Actually fix this issue (dont suppress)

Fixed all 50 new goconst findings (plus a few more that surfaced as duplicates were consolidated) by extracting the duplicated string literals into named constants — no nolint suppressions. golangci-lint run now reports 0 issues. See b86fb17.

[jmclong]

@copilot if we made some change in some series of key - values pairs or in a structure to add a const but didn't add consts for other parts of that object, can we add those also as consts

[Copilot]

@copilot if we made some change in some series of key - values pairs or in a structure to add a const but didn't add consts for other parts of that object, can we add those also as con...

Good catch. Extended the consts to nearby siblings in the same maps/structs/test series:

• internal/csi/core/lvm/: added testFailoverModeKey / testFailoverAvail (siblings of testCapacityKey/testLimitKey in the same Parameters/VolumeContext maps).
• internal/manager/pvcleanup/: added pvcTestNode4 / pvcTestNode5 (siblings of pvcTestNode1..3 in the same Node.Name test series).
• internal/gc/: added gcTestNode3 (sibling of gcTestNode1/gcTestNode2).
• internal/pkg/probe/: added modelSamsungV2 / modelIntel (siblings of modelSamsung in the same model-list literals).

Lint is still clean and tests pass. See d7138f9.

[jmclong]

@copilot if there are consts like these that are present in the source, can you make them accessible by the test and use the const from teh source? Do a thorough scan

				"localdisk.csi.acstor.io/capacity":      "1073741824",
				"localdisk.csi.acstor.io/limit":         "0",
				"localdisk.csi.acstor.io/failover-mode": "availability",

[Copilot]

@copilot if there are consts like these that are present in the source, can you make them accessible by the test and use the const from teh source? Do a thorough scan

  			"localdisk.csi.acstor.io/...

Done. Scanned the test consts I added and replaced any that mirrored a production source const with a direct reference (so they can't drift):

• internal/csi/core/lvm/testconst_test.go: testCapacityKey → lvm.CapacityParam, testLimitKey → lvm.LimitParam, testFailoverModeKey → hyperconverged.FailoverModeParam, testFailoverAvail → hyperconverged.FailoverModeAvailability, testTopologyNodeKey → lvm.TopologyKey, testDeviceTypeDisk → probe.DeviceTypeDisk, testVolumeFullID → lvm.DefaultVolumeGroup + "#" + testVolume, testVgTagsLocalCsi → "vg_tags=" + lvm.DefaultVolumeGroupTag.
• internal/gc/testconst_test.go: gcTestSelectedInitialNode → csi.SelectedInitialNodeParam, gcTestSelectedNode → csi.SelectedNodeAnnotation, gcTestVolumeGroup → lvm.DefaultVolumeGroup, gcTestVolumeFullID derived from gcTestVolumeGroup.
• internal/csi/node/node_test.go: bare "localdisk.csi.acstor.io/capacity" literals (in PV attributes and recovery error message) → lvm.CapacityParam.

To make this work I converted lvm.CapacityParam and lvm.LimitParam from var → const (they were already initialized from a const expression DriverName + "/...", so the change is mechanical and they're now usable in const blocks).

Lint still 0 issues, affected unit tests pass. See f8cf9df.