Skip to content

Fix Terminating Pending Orchestration Regression #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sophiatev wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Fix Terminating Pending Orchestration Regression #1288

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
340533e
first commit
Dec 11, 2025
a065ce5
updated the fix
Dec 11, 2025
6b7fff8
revert old fix
Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/DurableTask.AzureStorage/AzureStorageOrchestrationService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1073,11 +1073,16 @@ async Task<string> IsExecutableInstanceAsync(
TaskMessage executionTerminatedEventMessage = newMessages.LastOrDefault(msg => msg.Event is ExecutionTerminatedEvent);
if (executionTerminatedEventMessage is not null)
{
var executionTerminatedEvent = (ExecutionTerminatedEvent)executionTerminatedEventMessage.Event;
await this.trackingStore.UpdateStatusForTerminationAsync(
instanceId,
executionTerminatedEvent);
return $"Instance is {OrchestrationStatus.Terminated}";
InstanceStatus instanceStatus = await this.trackingStore.FetchInstanceStatusAsync(executionTerminatedEventMessage.OrchestrationInstance.InstanceId);
if (instanceStatus != null
&& instanceStatus.State.OrchestrationInstance.ExecutionId == executionTerminatedEventMessage.OrchestrationInstance.ExecutionId)
{
var executionTerminatedEvent = (ExecutionTerminatedEvent)executionTerminatedEventMessage.Event;
await this.trackingStore.UpdateStatusForTerminationAsync(
instanceId,
executionTerminatedEvent);
return $"Instance is {OrchestrationStatus.Terminated}";
}
}

// A non-zero event count usually happens when an instance's history is overwritten by a
Expand Down
Loading