Skip to content

Loosen exception matching logic in IsCausedBy<T> #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andystaples wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Loosen exception matching logic in IsCausedBy<T> #1236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions src/DurableTask.Core/FailureDetails.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,14 +149,10 @@ public bool IsCausedBy<T>() where T : Exception
.Select(a => a.GetType(this.ErrorType, throwOnError: false))
.Where(t => t is not null)
.ToList();
if (matchingExceptionTypes.Count == 1)
{
exceptionType = matchingExceptionTypes[0];
}
else if (matchingExceptionTypes.Count > 1)
{
throw new AmbiguousMatchException($"Multiple exception types with the name '{this.ErrorType}' were found.");
}

// Previously, this logic would only return true if matchingExceptionTypes found only one assembly with a type matching ErrorType.
// Now, it will return true if any matching assembly has a type that is assignable to T.
return matchingExceptionTypes.Any(matchType => typeof(T).IsAssignableFrom(matchType));
}

return exceptionType != null && typeof(T).IsAssignableFrom(exceptionType);
Expand Down
Loading