CreateTimer validation and more context for activity implementations

src/DurableTask.Core/DurableTask.Core.csproj

@@ -17,7 +17,7 @@
   <!-- Version Info -->
   <PropertyGroup>
     <MajorVersion>3</MajorVersion>
-    <MinorVersion>0</MinorVersion>
+    <MinorVersion>1</MinorVersion>
     <PatchVersion>0</PatchVersion>
     <VersionPrefix>$(MajorVersion).$(MinorVersion).$(PatchVersion)</VersionPrefix>
     <FileVersion>$(VersionPrefix).0</FileVersion>

src/DurableTask.Core/TaskActivityDispatcher.cs

@@ -184,7 +184,11 @@ await this.dispatchPipeline.RunAsync(dispatchContext, async _ =>
                             throw new TypeMissingException($"TaskActivity {scheduledEvent.Name} version {scheduledEvent.Version} was not found");
                         }
 
-                        var context = new TaskContext(taskMessage.OrchestrationInstance);
+                        var context = new TaskContext(
+                            taskMessage.OrchestrationInstance,
+                            scheduledEvent.Name,
+                            scheduledEvent.Version,
+                            scheduledEvent.EventId);
                         context.ErrorPropagationMode = this.errorPropagationMode;
 
                         HistoryEvent? responseEvent;

src/DurableTask.Core/TaskContext.cs

@@ -10,7 +10,7 @@
 //  See the License for the specific language governing permissions and
 //  limitations under the License.
 //  ----------------------------------------------------------------------------------
-
+#nullable enable
 namespace DurableTask.Core
 {
     /// <summary>
@@ -23,15 +23,41 @@ public class TaskContext
         /// </summary>
         /// <param name="orchestrationInstance"></param>
         public TaskContext(OrchestrationInstance orchestrationInstance)
+            : this(orchestrationInstance, string.Empty, null, -1)
+        {
+        }
+
+        /// <summary>
+        /// Creates a new TaskContext with the supplied OrchestrationInstance and taskId
+        /// </summary>
+        public TaskContext(OrchestrationInstance orchestrationInstance, string name, string? version, int taskId)
         {
             OrchestrationInstance = orchestrationInstance;
+            Name = name;
+            Version = version;
+            TaskId = taskId;
         }
 
         /// <summary>
         /// Gets the OrchestrationInstance for this task context
         /// </summary>
         public OrchestrationInstance OrchestrationInstance { get; private set; }
 
+        /// <summary>
+        /// Gets the name of the task
+        /// </summary>
+        public string Name { get; }
+
+        /// <summary>
+        /// Gets the version of the task, if any.
+        /// </summary>
+        public string? Version { get; }
+
+        /// <summary>
+        /// Gets the ID of the task, which is a sequential number unique to the orchestration instance.
+        /// </summary>
+        public int TaskId { get; }
+
         /// <summary>
         /// Gets or sets a value indicating how to propagate unhandled exception metadata.
         /// </summary>

src/DurableTask.Core/TaskOrchestrationContext.cs

@@ -245,6 +245,13 @@ public override Task<T> CreateTimer<T>(DateTime fireAt, T state)
 
         public override async Task<T> CreateTimer<T>(DateTime fireAt, T state, CancellationToken cancelToken)
         {
+            if (state is CancellationToken)
+            {
+                throw new ArgumentException(
+                    "The state parameter cannot be a CancellationToken. Did you mean to use a different overload?",
+                    paramName: nameof(state));
+            }
+
             int id = this.idCounter++;
             var createTimerOrchestratorAction = new CreateTimerOrchestratorAction
             {

test/DurableTask.AzureStorage.Tests/AzureStorageScenarioTests.cs

@@ -3148,7 +3148,7 @@ public override async Task<string> RunTask(OrchestrationContext context, TimeSpa
                     using (var cts = new CancellationTokenSource())
                     {
                         Task<bool> approvalTask = this.GetWaitForApprovalTask();
-                        Task timeoutTask = context.CreateTimer(deadline, cts.Token);
+                        Task timeoutTask = context.CreateTimer(deadline, true, cts.Token);
 
                         if (shouldFail)
                         {