Skip to content

Fix documentation typos in serialization comments #3057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alekhya-Polavarapu merged 2 commits into from
Jan 14, 2026
+5 −5
Merged

Fix documentation typos in serialization comments #3057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e21708b
Initial plan
Copilot Jan 13, 2026
2c7d515
Fix documentation typos in comments
Copilot Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Core/Services/MetadataProviders/Converters/DatabaseObjectConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ private static bool IsSourceDefinitionOrDerivedClassProperty(PropertyInfo prop)
}

/// <summary>
/// Escapes column keys that start with '$' to '_$' for serialization.
/// Escapes column keys that start with '$' by prefixing them with 'DAB_ESCAPE$' for serialization.
/// </summary>
private static void EscapeDollaredColumns(SourceDefinition sourceDef)
{
Expand All @@ -116,7 +116,7 @@ private static void EscapeDollaredColumns(SourceDefinition sourceDef)
}

/// <summary>
/// Unescapes column keys that start with '_$' to '$' for deserialization.
/// Unescapes column keys that start with 'DAB_ESCAPE$' by removing the prefix and restoring the original '$' for deserialization.
/// </summary>
private static void UnescapeDollaredColumns(SourceDefinition sourceDef)
{
Expand Down
6 changes: 3 additions & 3 deletions src/Service.Tests/UnitTests/SerializationDeserializationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ public void TestDictionaryDatabaseObjectSerializationDeserialization()
}

/// <summary>
/// Validates serialization and deserilization of Dictionary containing DatabaseTable
/// Validates serialization and deserialization of Dictionary containing DatabaseTable
/// The table will have dollar sign prefix ($) in the column name
/// this is how we serialize and deserialize metadataprovider.EntityToDatabaseObject dict.
/// </summary>
Expand Down Expand Up @@ -313,7 +313,7 @@ public void TestDictionaryDatabaseObjectSerializationDeserialization_WithDollarC
}

/// <summary>
/// Validates serialization and deserilization of Dictionary containing DatabaseView
/// Validates serialization and deserialization of Dictionary containing DatabaseView
/// The table will have dollar sign prefix ($) in the column name
/// this is how we serialize and deserialize metadataprovider.EntityToDatabaseObject dict.
/// </summary>
Expand Down Expand Up @@ -348,7 +348,7 @@ public void TestDatabaseViewSerializationDeserialization_WithDollarColumn()
}

/// <summary>
/// Validates serialization and deserilization of Dictionary containing DatabaseStoredProcedure
/// Validates serialization and deserialization of Dictionary containing DatabaseStoredProcedure
/// The table will have dollar sign prefix ($) in the column name
/// this is how we serialize and deserialize metadataprovider.EntityToDatabaseObject dict.
/// </summary>
Expand Down