Handle dollar-prefixed columns in SourceEntityRelationshipMap during serialization #3055
+151
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Addresses review feedback on #3051 where dollar-prefixed column names in
ForeignKeyDefinitionobjects withinSourceEntityRelationshipMapwere not being escaped/unescaped during serialization/deserialization, causing inconsistencies in relationship metadata.What is this change?
Extended the existing dollar-prefix escaping logic to handle relationship metadata:
SourceEntityRelationshipMap → RelationshipMetadata → ForeignKeyDefinitionand processReferencedColumnsandReferencingColumnslistsList<string>collections with null safetyescape → serialize → unescape) to prevent mutation issues with circular references when usingReferenceHandler.PreserveThe escaping pattern remains unchanged:
$ColumnName→DAB_ESCAPE$ColumnNameduring serialization, reversed during deserialization.How was this tested?
Added
TestSourceDefinitionRelationshipMapSerializationDeserialization_WithDollarColumnto verify dollar-prefixed columns in relationship metadata are properly escaped/unescaped. All 12 existing serialization/deserialization tests continue to pass.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.