#3053 Fix by using custom bool parsing that if a string is found then…

[simonsabin]

… it uses the environment replacement and looks for a true false 1 or 0.

Why make this change?

Fixes #3053

Boolean values can't be set using environment variables. This allows that

What is this change?

Using custom JsonConverter for bools that if a string is detected it uses the string serialiser that uses the environment replacement rules.

How was this tested?

• Integration Tests
• Unit Tests

[Copilot]

Pull request overview

This pull request fixes issue #3053 by enabling boolean configuration values to be set using environment variables. Previously, boolean values could not use environment variable substitution like string values could.

Changes:

• Added a custom BoolJsonConverter that handles boolean deserialization from both native JSON boolean tokens and string tokens (which enables environment variable substitution)
• Registered the new converter in the JSON serialization pipeline
• Added unit tests to validate boolean values can be set through environment variables

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.

File	Description
src/Config/Converters/BooleanJsonConverterFactory.cs	New custom JSON converter that deserializes boolean values from both JSON booleans and strings, enabling environment variable substitution
src/Config/RuntimeConfigLoader.cs	Registers the BoolJsonConverter in the serialization options
src/Service.Tests/UnitTests/RuntimeConfigLoaderJsonDeserializerTests.cs	Adds test coverage for boolean environment variable replacement

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Aniruddh25]

Should there be a test for the configValue itself be in double quotes? So,

"enabled" : "true" or
"enabled" : "@env('application_insights_enabled')"

[Aniruddh25]

Without this, the current test is not testing the scenario when configValue is hardcoded to true because this code will translate to "enabled": true,

[simonsabin]

putting a load more tests

[simonsabin]

a whole set of extra tests to handle string and non string booleans

[simonsabin]

test now check for true, false, 0, 1 natively, hardcoded within a string, or from an environment replacement.
Assuming keyvault replacements would "just work"

[Aniruddh25]

Additional testing for double quoted value boolean value to test the string deserialization.

[simonsabin]

Additional testing for double quoted value boolean value to test the string deserialization.

I think this is now catered for it you mean where the json is the following.

{
 .... 
  "enabled": "true"
  ...
}

and also

{
 .... 
   "enabled": true
  ...
}