Rename login to start and make it idempotent#889
Open
vicancy wants to merge 1 commit into
Open
Conversation
xingsy97
reviewed
May 21, 2026
Collaborator
There was a problem hiding this comment.
better to keep this ctor signature because it's aligned with ctor of WebPubSubClient https://github.com/Azure/azure-sdk-for-js/blob/f9cf40e732361e47a7944dd758d27af8d266aed9/sdk/web-pubsub/web-pubsub-client/src/webPubSubClient.ts#L140
xingsy97
reviewed
May 26, 2026
| public async start(): Promise<void> { | ||
| if (this._startPromise) return this._startPromise; | ||
| if (this._isStarted) return; | ||
| if (this._connectionStoppedTCS && this._isConnectionStopping) { |
Collaborator
There was a problem hiding this comment.
when the client is stopping, if start() is called twice, both will await here. After stop() done, two start() could call startCore() twice, leading to twice login and this.connection.start(). So start() is not idempotent enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.