Preserve explicit passed when handling _result/_label keys#46836
Draft
m7md7sien wants to merge 1 commit into
Draft
Preserve explicit passed when handling _result/_label keys#46836m7md7sien wants to merge 1 commit into
passed when handling _result/_label keys#46836m7md7sien wants to merge 1 commit into
Conversation
In `_update_metric_value`, the `_result`/`result`/`_label` branch unconditionally derived `passed` from the label value for `azure_ai_evaluator` criteria, overwriting any `passed` already set by an earlier `metric_key == "passed"` iteration. Guard the derivation with `"passed" not in metric_dict` so an explicitly provided `passed` value is preserved.
github-actions
Bot
added
the
Evaluation
Contributor
|
add unit tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
_update_metric_value, the_result/result/_labelbranch unconditionally derivedpassedfrom the label value forazure_ai_evaluatorcriteria, overwriting anypassedalready set by an earliermetric_key == "passed"iteration.Guard the derivation with
"passed" not in metric_dictso an explicitly providedpassedvalue is preserved.Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines