Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the resiliency of inline-markdown image handling in azure-ai-evaluation by treating invalid/unresolvable local image references as plain text rather than raising, specifically covering OS/path edge cases (e.g., overly long filenames and embedded null bytes).
Changes:
- Added unit tests covering filename-too-long and null-byte path scenarios for
_inline_imageand mixed-content parsing. - Updated
_inline_imageto catchOSError/ValueErrorduring local path resolution and fall back to returning a text chunk instead of throwing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sdk/evaluation/azure-ai-evaluation/tests/unittests/test_inline_image_fallback.py | Adds regression tests for long/invalid local image paths and mixed-content parsing behavior. |
| sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_legacy/prompty/_utils.py | Makes _inline_image handle invalid/too-long paths gracefully by returning text instead of raising. |
Comments suppressed due to low confidence (1)
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_legacy/prompty/_utils.py:447
- This branch resolves
Path/exists()up front, thenlocal_to_base64()re-resolves the same path and performs anotherexists()check. Consider refactoring so the resolvedPathis computed once (or solocal_to_base64accepts aPath) to avoid duplicate filesystem calls and duplicated path-resolution logic.
return {"type": "text", "text": image}
inlined_uri = local_to_base64(local_file, mime_type)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines