Use sdkReleaseType for tagIsStable in TypeSpec projects#45769
Merged
msyyc merged 2 commits intofix/tag-is-stable-typespecfrom Mar 19, 2026
Merged
Use sdkReleaseType for tagIsStable in TypeSpec projects#45769msyyc merged 2 commits intofix/tag-is-stable-typespecfrom
msyyc merged 2 commits intofix/tag-is-stable-typespecfrom
Conversation
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Update tagIsStable logic for TypeSpec projects
Use sdkReleaseType for tagIsStable in TypeSpec projects
Mar 18, 2026
msyyc
added a commit
that referenced
this pull request
Mar 19, 2026
* Use sdkReleaseType for tagIsStable in TypeSpec projects For TypeSpec projects, determine tagIsStable from sdkReleaseType input instead of using judge_tag_preview. Swagger projects continue to use judge_tag_preview as before. - Extract sdkReleaseType from pipeline input data - Add is_tsp flag to distinguish TypeSpec from Swagger codegen - TypeSpec: tagIsStable = (sdkReleaseType == 'stable') - Swagger: tagIsStable = not judge_tag_preview(...) - Add test_sdk_generator.py with 9 test cases covering the new logic * Use sdkReleaseType for tagIsStable in TypeSpec projects (#45769) * Initial plan * Fix Black formatting in test_sdk_generator.py Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> * update * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For TypeSpec projects,
tagIsStableshould be derived from thesdkReleaseTypepipeline input rather thanjudge_tag_preview, which inspects swagger tags. Swagger projects continue usingjudge_tag_previewas before.Changes
eng/tools/azure-sdk-tools/packaging_tools/sdk_generator.pysdkReleaseTypefrom pipeline input datais_tspflag to distinguish TypeSpec from Swagger codegentagIsStable = (sdkReleaseType == "stable")tagIsStable = not judge_tag_preview(...)eng/tools/azure-sdk-tools/tests/test_sdk_generator.py— New test file covering:sdkReleaseType="stable","preview", and missingjudge_tag_previewfor both stable and previewextract_sdk_folderandget_readme_python_content📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.