Remove tox from various scripts by JennyPng · Pull Request #45756 · Azure/azure-sdk-for-python

JennyPng · 2026-03-17T20:30:00Z

Related to #42858

removing mentions of tox across code and variable names
continuation of work in Update docs and instructions to use azpysdk instead of tox #45480 , which mainly removes mentions of tox in docs and instructions files, and removes unused ymls

usages of tox addressed:

todo in a separate PR

rename ToxEnvParallel
rename TOX_PIP_IMPL ? (across yml files, azpysdk/main.py)
mentions of tox under extend_skip_glob in 3 pyproject.tomls
move run_coverage.py out of eng/tox
- delete entire eng/tox folder
- delete create_coverage.py ?
remove unnecessary mentions of tox across code comments

pipeline check

core: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6030236&view=results

Copilot

Pull request overview

This PR continues the repo-wide move away from tox by removing tox-based CI scripts/variables and switching remaining usage to azpysdk-based check execution.

Changes:

Replaces tox invocations/variables in pipeline templates with azpysdk/checks terminology (e.g., ToxTestEnv → CheckEnv, toxenv → checks).
Deletes legacy tox dispatch/harness scripts and removes related helper logic.
Removes tox from tooling requirement files and the azure-sdk-tools optional dependency list.

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
sdk/cosmos/cosmos-staging.yml	Switches Cosmos staging job from `tox` to `azpysdk whl`.
scripts/devops_tasks/tox_harness.py	Deletes legacy tox harness implementation.
scripts/devops_tasks/dispatch_tox.py	Deletes legacy tox dispatch entrypoint.
eng/tools/azure-sdk-tools/pyproject.toml	Removes `tox` from the `sdkgenerator` extra.
eng/tools/azure-sdk-tools/packaging_tools/package_utils.py	Updates breaking-change invocation to use `azpysdk`.
eng/tools/azure-sdk-tools/gh_tools/vnext_issue_creator.py	Updates issue template instructions from tox to `azpysdk`.
eng/tools/azure-sdk-tools/ci_tools/environment_exclusions.py	Removes tox-environment filtering helper tied to the deleted harness.
eng/scripts/set_checks.py	Renames “tox env” handling to “checks” and updates output variable name.
eng/scripts/invoke-tox-parallel.ps1	Deletes legacy tox parallel dispatcher script.
eng/regression_tools.txt	Removes tox pin from regression tooling requirements.
eng/ci_tools.txt	Removes tox pin from CI tooling requirements.
eng/pipelines/templates/steps/run_pyright.yml	Removes TOX-specific env overrides from pyright step.
eng/pipelines/templates/steps/run_pylint.yml	Removes TOX-specific env overrides from pylint step.
eng/pipelines/templates/steps/run_mypy.yml	Removes TOX-specific env overrides from mypy step.
eng/pipelines/templates/steps/run_breaking_changes.yml	Removes TOX-specific env overrides from breaking-changes step.
eng/pipelines/templates/steps/run_black.yml	Removes TOX-specific env overrides from black step.
eng/pipelines/templates/steps/run_bandit.yml	Removes TOX-specific env overrides from bandit step.
eng/pipelines/templates/steps/build-test.yml	Renames parameter `ToxTestEnv` → `CheckEnv` and uses `--checks` accordingly.
eng/pipelines/templates/steps/build-extended-artifacts.yml	Removes TOX-specific env overrides from docs build step.
eng/pipelines/templates/steps/analyze.yml	Removes TOX-specific env overrides from analysis steps.
eng/pipelines/templates/stages/archetype-sdk-tests.yml	Renames stage parameter `ToxTestEnv` → `CheckEnv`.
eng/pipelines/templates/jobs/live.tests.yml	Renames job parameter `ToxTestEnv` → `CheckEnv`.
eng/pipelines/templates/jobs/ci.tests.yml	Wires `CheckEnv` from `$(checks)` instead of `$(toxenv)`.

Comments suppressed due to low confidence (1)

scripts/devops_tasks/dispatch_tox.py:1

This script is being deleted, but there are still pipeline definitions in the repo that invoke scripts/devops_tasks/dispatch_tox.py (e.g., eng/pipelines/generate-all-docs.yml, eng/pipelines/templates/jobs/tests-nightly-python.yml, and eng/pipelines/templates/steps/release-candidate-steps.yml). Removing it without updating/removing those callers will break those pipelines. Either update those pipelines to use eng/scripts/dispatch_checks.py / azpysdk, or keep a small compatibility shim that forwards to the new entrypoint.

You can also share your feedback on Copilot code review. Take the survey.

JennyPng · 2026-03-18T21:24:49Z

sdk/cosmos/cosmos-staging.yml

      script: >-
        cd ./sdk/cosmos/azure-cosmos

-        pip install tox==4.5.0
-
-        tox -c ../../../eng/tox/tox.ini --root . -e whl -- -k 'not cosmosEmulator and not cosmosMultiRegion and not cosmosCircuitBreaker and not cosmosCircuitBreakerMultiRegion'
+        azpysdk whl --pytest-args -k 'not cosmosEmulator and not cosmosMultiRegion and not cosmosCircuitBreaker and not cosmosCircuitBreakerMultiRegion'
    env:


I don't actually know where this yml file is used

eng/tools/azure-sdk-tools/gh_tools/vnext_issue_creator.py

JennyPng · 2026-03-18T21:47:29Z

eng/tools/azure-sdk-tools/packaging_tools/package_utils.py

 def change_log_new(package_folder: str, lastest_pypi_version: bool) -> str:
    os.chdir(package_folder)
-    cmd = f"{sys.executable} -m tox run -c ../../../eng/tox/tox.ini --root . -e breaking --  --changelog "
+    cmd = "azpysdk breaking --changelog"
    if lastest_pypi_version:
-        cmd += "--latest-pypi-version"
+        cmd += " --latest-pypi-version"
    try:


I wasn't sure about this but it def can't be invoked as <executable> -m azpysdk bc it's not a module

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

scbedd · 2026-03-18T23:25:33Z

eng/tools/azure-sdk-tools/pyproject.toml

 conda = ["beautifulsoup4"]
 systemperf = ["aiohttp>=3.0", "requests>=2.0", "tornado==6.0.3", "httpx>=0.21", "azure-core"]
 ghtools = ["GitPython", "PyGithub>=1.59.0", "requests>=2.0"]
-sdkgenerator = ["tox"]


I agree with this. Plox double check through the whole repo to ensure this isn't used by a management script though. CC @msyyc for FYI.

scbedd · 2026-03-18T23:26:42Z

sdk/cosmos/cosmos-staging.yml

-        pip install tox==4.5.0
-
-        tox -c ../../../eng/tox/tox.ini --root . -e whl -- -k 'not cosmosEmulator and not cosmosMultiRegion and not cosmosCircuitBreaker and not cosmosCircuitBreakerMultiRegion'
+        azpysdk whl --pytest-args -k 'not cosmosEmulator and not cosmosMultiRegion and not cosmosCircuitBreaker and not cosmosCircuitBreakerMultiRegion'


The fact that tox wasn't installed before makes me think that we never installed eng/ci_tools.txt earlier in whatever is calling this. That means that azpysdk won't be present either.

scbedd

Have a couple questions. Looks great otherwise.

JennyPng added 6 commits March 17, 2026 13:20

rename ToxTestEnv

e094c86

update vnext issue instr

3e0f222

update package_utils changelog func

f7234ec

remove unnecessary TOX_PIP_IMPL setting

131f8ac

remove tox from cosmos-staging

58fe5c7

delete dispatch_tox and related logic

38b82e0

JennyPng marked this pull request as ready for review March 18, 2026 21:16

JennyPng requested review from a team, benbp, mccoyp, scbedd and weshaggard as code owners March 18, 2026 21:16

Copilot AI review requested due to automatic review settings March 18, 2026 21:16

Copilot AI reviewed Mar 18, 2026

View reviewed changes

minor

0413509

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

scbedd reviewed Mar 18, 2026

View reviewed changes

scbedd requested changes Mar 18, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove tox from various scripts#45756

Remove tox from various scripts#45756
JennyPng wants to merge 7 commits intoAzure:mainfrom
JennyPng:remove-tox-scripts

JennyPng commented Mar 17, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

JennyPng Mar 18, 2026

Uh oh!

Uh oh!

JennyPng Mar 18, 2026

Uh oh!

scbedd Mar 18, 2026 •

edited

Loading

Uh oh!

scbedd Mar 18, 2026 •

edited

Loading

Uh oh!

scbedd left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

JennyPng commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

usages of tox addressed:

todo in a separate PR

pipeline check

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

JennyPng Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JennyPng Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

scbedd Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

scbedd Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

scbedd left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JennyPng commented Mar 17, 2026 •

edited

Loading

scbedd Mar 18, 2026 •

edited

Loading

scbedd Mar 18, 2026 •

edited

Loading