[AutoPR azure-resourcemanager-monitor-slis]-generated-from-SDK Generation - Java-6342625#49251
Open
azure-sdk wants to merge 14 commits into
Open
[AutoPR azure-resourcemanager-monitor-slis]-generated-from-SDK Generation - Java-6342625#49251azure-sdk wants to merge 14 commits into
azure-sdk wants to merge 14 commits into
Conversation
…rosoft.Monitor/Slis/tspconfig.yaml', API Version: 2025-03-01-preview, SDK Release Type: beta, and CommitSHA: '8be8c75d9bb11ea95d8a7e251db74aa78b5cd76c' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6342625 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
azure-sdk
requested review from
a team,
ArthurMa1978,
XiaofeiCao,
haolingdong-msft and
weidongxu-microsoft
as code owners
github-actions
Bot
added
the
Mgmt
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the generated azure-resourcemanager-monitor-slis (beta) package to align with the latest TypeSpec/spec snapshot for Microsoft.Monitor/Slis (2025-03-01-preview), including regenerated models/tests and updated release artifacts.
Changes:
- Bumps the spec commit reference in
tsp-location.yamland regenerates the SDK accordingly. - Updates several expandable enums’ serialized values (e.g.,
ConditionOperator,SamplingType,WindowUptimeCriteriaComparator) and refreshes generated tests/mocks to match. - Updates package metadata and docs (README version + CHANGELOG entries).
Reviewed changes
Copilot reviewed 8 out of 19 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/monitor/azure-resourcemanager-monitor-slis/tsp-location.yaml | Updates the referenced swagger/TypeSpec commit SHA for regeneration. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/WindowUptimeCriteriaTests.java | Updates comparator wire value used in deserialization test. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/SlisListByParentMockTests.java | Updates mock payload comparator wire value. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/SlisGetWithResponseMockTests.java | Updates mock payload comparator wire value. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/SlisCreateOrUpdateWithResponseMockTests.java | Updates mock payload comparator wire value. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/SliResourceTests.java | Updates deserialization payload to new operator/sampling/comparator values. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/SliPropertiesTests.java | Updates operator/sampling values and assertions for SamplingType changes. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/SliListResultTests.java | Updates comparator wire values in list-result test payload. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/SliInnerTests.java | Updates operator/sampling/comparator values in inner-model payload. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/SignalTests.java | Updates operator/sampling values and related assertions. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/SignalSourceTests.java | Updates sampling/operator wire values and assertions. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/ConditionTests.java | Updates sampling/operator wire values and assertions. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/resources/META-INF/azure-resourcemanager-monitor-slis_metadata.json | Updates generated metadata (adds cross-language package/version fields). |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/WindowUptimeCriteriaComparator.java | Updates comparator serialized values (lt/gt/lte/gte). |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/SamplingType.java | Reworks sampling-type values and removes AVG in favor of new set (AVERAGE, COUNT, etc.). |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/ConditionOperator.java | Updates operator serialized values (eq/ne/lt/..., in/notin, etc.) and adds explanatory docs. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/Condition.java | Expands documentation for value formatting for in/notin operators. |
| sdk/monitor/azure-resourcemanager-monitor-slis/README.md | Bumps dependency snippet version to 1.0.0-beta.2. |
| sdk/monitor/azure-resourcemanager-monitor-slis/CHANGELOG.md | Updates the 1.0.0-beta.2 section with release notes (needs adjustments per review comments). |
Contributor
|
Layered CRUD recording-based test scaffolding (test: Pipeline status: Regen pipeline 6342625 finished as PartiallySucceeded (see pipeline link in PR description), but PR was created as expected. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Drop @liveonly annotation and rebuild test atop TestProxyTestBase - Use interceptorManager record policy / playback client to route through test-proxy - Hard-code sanitized subscription id in playback to match scrubbed recording - Use testResourceNamer.randomName so sli name is replayed deterministically - Push session-record to azure-sdk-assets (Tag java/monitor/azure-resourcemanager-monitor-slis_7b447d0598) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Introduce a hand-written sibling utility class ConditionValues in the models package, alongside the generated final Condition class. It exposes values(Condition), withValues(Condition, List), and forListOperator(ConditionOperator, List) helpers that round-trip through the wire `value` string by joining/splitting on the ^^ separator used by the SLI resource provider for the in/notin operators. forListOperator rejects non-list operators, empty lists, and items containing the reserved separator. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This reverts commit 5e19002. The SDK-side ^^-splitting customization papers over a wire-format quirk that should be fixed in the service contract instead. Drop the customization until the service exposes a structured `values` field; once it does, the SDK will surface it naturally without us hand-rolling a parser whose round-trip / mutability semantics are non-obvious. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
/azp run prepare-pipelines |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run prepare-pipelines |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/monitoringservice/resource-manager/Microsoft.Monitor/Slis/tspconfig.yaml', API Version: 2025-03-01-preview, SDK Release Type: beta, and CommitSHA: '8be8c75d9bb11ea95d8a7e251db74aa78b5cd76c' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6342625 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=2199 Submitted by: Saleel.Kattiyat@microsoft.com
Release Plan Details