-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Batch - Release for GA #48252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ReneOv-MSFT
wants to merge
29
commits into
main
Choose a base branch
from
renojeda/release/1.0.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Batch - Release for GA #48252
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
b6f61b9
Release for GA
ReneOv-MSFT ef1328d
Update sdk/batch/azure-compute-batch/CHANGELOG.md
ReneOv-MSFT adf1ca3
Release for GA
ReneOv-MSFT c34fd31
Merge branch 'renojeda/release/1.0.0' of https://github.com/Azure/azu…
ReneOv-MSFT 38886dc
Other Changes subheader
ReneOv-MSFT 7c1ad0e
WIP: Api-review
ReneOv-MSFT a1f7bbb
WIP: Api-review
ReneOv-MSFT 05c8304
Update sdk/batch/azure-compute-batch/CHANGELOG.md
ReneOv-MSFT 41c13b6
Other Changes subheader
ReneOv-MSFT 17b3dec
WIP: Api-review
ReneOv-MSFT 58d4543
WIP: Api-review
ReneOv-MSFT d5ecd96
API view review
ReneOv-MSFT 193572c
API view review
ReneOv-MSFT 875377b
Update sdk/batch/azure-compute-batch/CHANGELOG.md
ReneOv-MSFT d990d0e
Other Changes subheader
ReneOv-MSFT d482a93
WIP: Api-review
ReneOv-MSFT 07609b4
WIP: Api-review
ReneOv-MSFT dff817b
API Review: AzureNamedKeyCredential
ReneOv-MSFT 17f26fc
Add customization directory for required imports
ReneOv-MSFT 17f1473
Update TypeSpec and run customization
ReneOv-MSFT 0f221c7
Merge branch 'main' into renojeda/release/1.0.0
ReneOv-MSFT babac90
API-view review part 3
ReneOv-MSFT 75c2da1
rene patch
wiboris 3f33b09
Merge branch 'main' into renojeda/release/1.0.0
ReneOv 24a963c
Update from main
ReneOv-MSFT d3ce00a
Merge branch 'main' into renojeda/release/1.0.0
ReneOv 0548c83
Remove unused import
ReneOv-MSFT bf3addf
Merge branch 'renojeda/release/1.0.0' of https://github.com/Azure/azu…
ReneOv-MSFT 10ef8d6
Merge branch 'main' into renojeda/release/1.0.0
ReneOv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
...atch/azure-compute-batch/customization/src/main/java/BatchClientBuilderCustomization.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import com.azure.autorest.customization.Customization; | ||
| import com.azure.autorest.customization.LibraryCustomization; | ||
| import com.github.javaparser.ast.NodeList; | ||
| import com.github.javaparser.ast.type.ClassOrInterfaceType; | ||
| import org.slf4j.Logger; | ||
|
|
||
| public class BatchClientBuilderCustomization extends Customization { | ||
| @Override | ||
| public void customize(LibraryCustomization customization, Logger logger) { | ||
| customization.getClass("com.azure.compute.batch", "BatchClientBuilder").customizeAst(ast -> { | ||
| // Add AzureNamedKeyCredentialTrait imports to BatchClientBuilder | ||
| ast.addImport("com.azure.core.client.traits.AzureNamedKeyCredentialTrait"); | ||
|
|
||
| ast.getClassByName("BatchClientBuilder").ifPresent(clazz -> { | ||
| NodeList<ClassOrInterfaceType> implementedTypes = clazz.getImplementedTypes(); | ||
| boolean hasKeyCredentialTrait = implementedTypes.stream() | ||
| .filter(implementedType -> implementedType.getNameAsString().equals("AzureNamedKeyCredentialTrait")) | ||
| .findFirst() | ||
| .isPresent(); | ||
| if (!hasKeyCredentialTrait) { | ||
| clazz.addImplementedType("AzureNamedKeyCredentialTrait<BatchClientBuilder>"); | ||
| } | ||
| }); | ||
| }); | ||
| } | ||
| } |
21 changes: 21 additions & 0 deletions
21
sdk/batch/azure-compute-batch/customization/src/main/pom.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project xmlns="http://maven.apache.org/POM/4.0.0" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <parent> | ||
| <groupId>com.azure</groupId> | ||
| <artifactId>azure-code-customization-parent</artifactId> | ||
| <version>1.0.0-beta.1</version> <!-- {x-version-update;com.azure:azure-code-customization-parent;current} --> | ||
| <relativePath>../../../parents/azure-code-customization-parent</relativePath> | ||
| </parent> | ||
|
|
||
| <name>Microsoft Azure client library for Batch</name> | ||
| <description>This package contains the Microsoft Azure Batch client library.</description> | ||
|
|
||
| <groupId>com.azure.tools</groupId> | ||
| <artifactId>azure-compute-batch-customization</artifactId> | ||
| <version>1.0.0-beta.1</version> | ||
| <packaging>jar</packaging> | ||
| </project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.