Skip to content

Fix java - spring - tests by adding Thread.sleep#47990

Merged
alzimmermsft merged 7 commits intomainfrom
rujche/main/fix-failure-in-java-spring-tests
Feb 12, 2026
Merged

Fix java - spring - tests by adding Thread.sleep#47990
alzimmermsft merged 7 commits intomainfrom
rujche/main/fix-failure-in-java-spring-tests

Conversation

@rujche
Copy link
Member

@rujche rujche commented Feb 12, 2026

Changes

  1. Fix the failure by adding Thread.sleep. The previous “fix” from updating netty likely just happened to pass by chance.
  2. Change the dependency management from before existing dependencies to after existing dependencies. This logic is not used anymore. Keep it in case it be used in the future.
  3. Delete unnecessary change in pom.xml and external_dependencies.txt about adding dependencyManagement section.

The problem has been fixed

@rujche rujche requested a review from moarychan as a code owner February 12, 2026 02:27
Copilot AI review requested due to automatic review settings February 12, 2026 02:27
@rujche rujche requested review from a team, Netyyyy and saragluna as code owners February 12, 2026 02:27
@github-actions github-actions bot added the azure-spring All azure-spring related issues label Feb 12, 2026
@rujche
Copy link
Member Author

rujche commented Feb 12, 2026

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes Java Spring tests by changing how the compatibility_insert_dependencymanagement.py script inserts Spring Boot and Spring Cloud dependencies into Maven POMs. The script now inserts these dependencies at the END of the dependencyManagement dependencies list instead of at the BEGINNING.

Changes:

  • Modified dependency insertion logic to append dependencies before the closing </dependencies> tag instead of after the opening tag
  • Added handling for POMs that have <dependencyManagement> but no <dependencies> section
  • Adjusted whitespace in string templates to remove leading newlines

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
sdk/spring/spring-cloud-azure-integration-tests/pom.xml Added TODO comment referencing issue #47812
sdk/spring/scripts/compatibility_insert_dependencymanagement.py Changed insertion position from beginning to end of dependencies list; added handling for empty dependencyManagement sections; adjusted string formatting

@rujche
Copy link
Member Author

rujche commented Feb 12, 2026

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rujche rujche self-assigned this Feb 12, 2026
@rujche rujche added this to the 2026-03 milestone Feb 12, 2026
@rujche rujche moved this from Todo to In Progress in Spring Cloud Azure Feb 12, 2026
@rujche
Copy link
Member Author

rujche commented Feb 12, 2026

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rujche rujche requested a review from a team as a code owner February 12, 2026 08:04
@rujche
Copy link
Member Author

rujche commented Feb 12, 2026

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rujche
Copy link
Member Author

rujche commented Feb 12, 2026

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rujche
Copy link
Member Author

rujche commented Feb 12, 2026

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rujche rujche changed the title Fix java - spring - tests by changing the position of inserted spring-boot-dependencies Fix java - spring - tests by adding Thread.sleep Feb 12, 2026
@alzimmermsft alzimmermsft merged commit 0cd44d7 into main Feb 12, 2026
81 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Spring Cloud Azure Feb 12, 2026
@alzimmermsft alzimmermsft deleted the rujche/main/fix-failure-in-java-spring-tests branch February 12, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants