-
Notifications
You must be signed in to change notification settings - Fork 2.2k
App Configuration Provider - Tag filters #47985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -35,50 +35,68 @@ public final class AppConfigurationKeyValueSelector { | |||||||||||
|
|
||||||||||||
| @NotNull | ||||||||||||
| /** | ||||||||||||
| * Key filter to use when loading configurations. The default value is | ||||||||||||
| * "/application/". The key filter is used to filter configurations by key. | ||||||||||||
| * The key filter must be a non-null string that does not contain an asterisk. | ||||||||||||
| * Filters configurations by key prefix. Defaults to {@code /application/} when | ||||||||||||
| * not explicitly set. Must not be {@code null} or contain asterisks ({@code *}). | ||||||||||||
| */ | ||||||||||||
| private String keyFilter = ""; | ||||||||||||
|
|
||||||||||||
| /** | ||||||||||||
| * Label filter to use when loading configurations. The label filter is used to | ||||||||||||
| * filter configurations by label. If the label filter is not set, the default | ||||||||||||
| * value is the current active Spring profiles. If no active profiles are set, | ||||||||||||
| * then all configurations with no label are loaded. The label filter must be a | ||||||||||||
| * non-null string that does not contain an asterisk. | ||||||||||||
| * Filters configurations by label. When unset, defaults to the active Spring | ||||||||||||
| * profiles; if no profiles are active, only configurations with no label are | ||||||||||||
| * loaded. Multiple labels can be specified as a comma-separated string. Must | ||||||||||||
| * not contain asterisks ({@code *}). | ||||||||||||
| */ | ||||||||||||
| private String labelFilter; | ||||||||||||
|
|
||||||||||||
| /** | ||||||||||||
| * Snapshot name to use when loading configurations. The snapshot name is used | ||||||||||||
| * to load configurations from a snapshot. If the snapshot name is set, the key | ||||||||||||
| * and label filters must not be set. The snapshot name must be a non-null | ||||||||||||
| * string that does not contain an asterisk. | ||||||||||||
| * Filters configurations by tags. Each entry must follow the {@code tagName=tagValue} | ||||||||||||
| * format. When multiple entries are provided, they are combined using AND logic. | ||||||||||||
|
Comment on lines
+52
to
+53
|
||||||||||||
| * Filters configurations by tags. Each entry must follow the {@code tagName=tagValue} | |
| * format. When multiple entries are provided, they are combined using AND logic. | |
| * Filters configurations by tags. Each entry is interpreted as a tag-based filter, | |
| * typically in the {@code tagName=tagValue} format. When multiple entries are | |
| * provided, they are combined using AND logic. |
Copilot
AI
Feb 12, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JavaDoc says snapshotName “Must not contain asterisks (*)”, but validateAndInit() doesn’t currently check snapshotName for *. Either add the corresponding validation (fail fast) or remove that constraint from the JavaDoc so it matches actual behavior.
| * key, label, or tag filters. Must not contain asterisks ({@code *}). | |
| * key, label, or tag filters. |
Uh oh!
There was an error while loading. Please reload this page.