Azd error handling modification #47975
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
azd auth tokenwrites JSON to stderr on failure:{"type":"consoleMessage","timestamp":"...","data":{"message":"\nERROR: fetching token: ..."}}AzureDeveloperCliCredential includes this raw JSON in error messages, producing noisy output like:
This PR uses the existing
extractUserFriendlyErrorFromAzdOutput()method to output data.message to the users.The issue description also mentioned that we'd want to show raw output on failure, hence when data.message or message is null, we return the raw output to the user. Lastly, with this change we want to remove any special-case error handling (e.g., substituting another message when azd's contains "azd auth login") because the parsed messages from azd are already user-friendly.
Fixes #47920
Azd logged in but wrong scope-
Azd logged out