Remove System.exit(1) from async samples #47966
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses feedback from #47952:
System.exit(1)in async samples terminates the JVM, breaking any application that embeds or copies this code.Changes
Removed
System.exit(1)from error handlers in three async samples:Sample06_GetAnalyzerAsync.java- UsesdoFinally()for cleanupSample15_GrantCopyAuthAsync.java- Uses explicitlatch.countDown()in handlersSample16_CreateAnalyzerWithLabelsAsync.java- Uses explicitlatch.countDown()in handlersPattern
Before:
After (doFinally pattern):
After (explicit pattern):
Both patterns allow errors to propagate naturally without killing the process.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.