[TSP Migration][authorization-12-01]TypeSpec migrated from swagger#41617
Merged
pshao25 merged 65 commits intoAzure:mainfrom Apr 9, 2026
Merged
[TSP Migration][authorization-12-01]TypeSpec migrated from swagger#41617pshao25 merged 65 commits intoAzure:mainfrom
pshao25 merged 65 commits intoAzure:mainfrom
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.Comment generated by summarize-checks workflow run. |
…llan/azure-rest-api-specs into wave6-authorization-convert
Member
|
@mcgallan - Please address Required CI checks that are failing (Swagger Avodado and Swagger ModelValidation). |
Member
|
Avocado failed because of multiple API. ModelValidation failed because the original swagger doesn't have examples. |
pshao25
approved these changes
Apr 9, 2026
markcowl
pushed a commit
to markcowl/azure-rest-api-specs
that referenced
this pull request
Apr 9, 2026
…zure#41617) * convert * convert1 * convert AccessReview * update * RoleAssignment compile * authorization compile * fix usertype * update * add common * add suppress * remove operationId * update * delete * delete agent * fix cspell * fix pipeline error * fix common type * fix model validation * compile * rename namespaces * fix armCommonTypesVersion * Revert "fix armCommonTypesVersion" This reverts commit 0243e28. * update client.tsp * regen * update * revert * fix modelvalidation * update readme * update * add x-ms-path * update x-ms-path * add suppress * rename folder * update * update suppress * update tspconfig * rename ClassicAdmin * update client name * Fix Authorization refreshAll LRO response shape * Use go alternateType for DenyAssignmentPrincipalType * fix finalresult * Update client.tsp * Update client.tsp * Update ProviderOperationsMetadata.tsp * Update client.tsp * Update client.tsp * java tspconfig * Update tspconfig and client.tsp for Java authorization migration - Add premium: true to preserve hand-written files - Add use-object-for-unknown: true for unknown type support - Add @@Usage for RoleAssignment as input model in Java Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * turn off samples * update * fix * fix * add x-ms-skip-url-encoding * update readme * add file * update --------- Co-authored-by: Jiao Di (MSFT) <v-jiaodi@microsoft.com> Co-authored-by: judy <v-liujudy@microsoft.com> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> Co-authored-by: Weidong Xu <weidxu@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Pan Shao <97225342+pshao25@users.noreply.github.com>
This was referenced Apr 10, 2026
Ealianis
pushed a commit
that referenced
this pull request
Apr 17, 2026
…41617) * convert * convert1 * convert AccessReview * update * RoleAssignment compile * authorization compile * fix usertype * update * add common * add suppress * remove operationId * update * delete * delete agent * fix cspell * fix pipeline error * fix common type * fix model validation * compile * rename namespaces * fix armCommonTypesVersion * Revert "fix armCommonTypesVersion" This reverts commit 0243e28. * update client.tsp * regen * update * revert * fix modelvalidation * update readme * update * add x-ms-path * update x-ms-path * add suppress * rename folder * update * update suppress * update tspconfig * rename ClassicAdmin * update client name * Fix Authorization refreshAll LRO response shape * Use go alternateType for DenyAssignmentPrincipalType * fix finalresult * Update client.tsp * Update client.tsp * Update ProviderOperationsMetadata.tsp * Update client.tsp * Update client.tsp * java tspconfig * Update tspconfig and client.tsp for Java authorization migration - Add premium: true to preserve hand-written files - Add use-object-for-unknown: true for unknown type support - Add @@Usage for RoleAssignment as input model in Java Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * turn off samples * update * fix * fix * add x-ms-skip-url-encoding * update readme * add file * update --------- Co-authored-by: Jiao Di (MSFT) <v-jiaodi@microsoft.com> Co-authored-by: judy <v-liujudy@microsoft.com> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> Co-authored-by: Weidong Xu <weidxu@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Pan Shao <97225342+pshao25@users.noreply.github.com>
Ealianis
pushed a commit
that referenced
this pull request
Apr 17, 2026
…41617) * convert * convert1 * convert AccessReview * update * RoleAssignment compile * authorization compile * fix usertype * update * add common * add suppress * remove operationId * update * delete * delete agent * fix cspell * fix pipeline error * fix common type * fix model validation * compile * rename namespaces * fix armCommonTypesVersion * Revert "fix armCommonTypesVersion" This reverts commit 0243e28. * update client.tsp * regen * update * revert * fix modelvalidation * update readme * update * add x-ms-path * update x-ms-path * add suppress * rename folder * update * update suppress * update tspconfig * rename ClassicAdmin * update client name * Fix Authorization refreshAll LRO response shape * Use go alternateType for DenyAssignmentPrincipalType * fix finalresult * Update client.tsp * Update client.tsp * Update ProviderOperationsMetadata.tsp * Update client.tsp * Update client.tsp * java tspconfig * Update tspconfig and client.tsp for Java authorization migration - Add premium: true to preserve hand-written files - Add use-object-for-unknown: true for unknown type support - Add @@Usage for RoleAssignment as input model in Java Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * turn off samples * update * fix * fix * add x-ms-skip-url-encoding * update readme * add file * update --------- Co-authored-by: Jiao Di (MSFT) <v-jiaodi@microsoft.com> Co-authored-by: judy <v-liujudy@microsoft.com> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> Co-authored-by: Weidong Xu <weidxu@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Pan Shao <97225342+pshao25@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates your latest version (identified by the tag in your readme.md) of swagger to TypeSpec. We already tried our best to make sure the TypeSpec represents same as previous swagger. Since we lack the business knowledge, please validate this PR again to make sure it's functional equivalent as before. The local validation step is at Getting started | TypeSpec Azure
Besides, TypeSpec encourages to follow ARM guidelines. Therefore, some representations in your previous swagger will be fixed to follow these guidelines. When you see differences in your local validation, please keep this note in mind.
Please reach out to TypeSpec Discussions Channel if there is any help needed.
The following known differences were identified during the migration from Swagger to TypeSpec and are documented here for transparency:
1.x-ms-azure-rbac-permissions-required not yet supported — The x-ms-azure-rbac-permissions-required extension used in the ClassicAdmin spec cannot currently be expressed in TypeSpec. A dedicated decorator to support this extension is planned for a future update.
2.x-ms-client-flatten removed due to discriminator conflict — The @flattenProperty decorator has been removed from AccessReviewDecisionProperties.principal, AccessReviewDecisionInsight.properties, AlertIncident.properties, and AlertConfiguration.properties, as property flattening is incompatible with discriminated union types in TypeSpec.
3.Extra x-ms-identifiers on RoleAssignmentListResult — The generated output for RoleAssignmentListResult in RoleAssignment.Management includes an unintended x-ms-identifiers annotation (["roleAssignmentName", "id"]). This is a known TypeSpec emitter behavior and will be addressed.
4.x-ms-discriminator-value emitted for derived models — In the 2024-09-01-preview openapi.json, models that extend a base model decorated with @Discriminator will emit x-ms-discriminator-value in the generated Swagger. This is expected TypeSpec behavior.
5.UserType naming conflict — Two distinct UserType definitions with different content exist across the specs. To resolve the naming collision, they have been temporarily renamed to CommonUserType and UserType respectively. A long-term resolution is pending.
6.PolicyProperties loses readOnly when used as resource properties — When PolicyProperties is referenced as the properties bag of a resource model, the readOnly constraint on its fields is not preserved in the generated output. This is a known limitation and will be investigated.